[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#693740: marked as done (unblock (pre-approval): rawtherapee/4.0.9-4)

Your message dated Tue, 20 Nov 2012 19:53:46 +0000
with message-id <1353441226.19688.3.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#693740: unblock (pre-approval): rawtherapee/4.0.9-4
has caused the Debian Bug report #693740,
regarding unblock (pre-approval): rawtherapee/4.0.9-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
693740: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693740
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package rawtherapee

I'd like to check the chance for unblocking before bothering my sponsor.
A user made me consider this problem as RC today:
RawTherapee corrupts Exif MarkerNotes for some Canon cameras. This was reported
on upstreams bugtracker and is fixed upstream for five month now. The patch is
only one line and fixes the bug by using the correct size for multi-byte EXIF
tags which use TagDirectoryTable. As no problem was reported I think the patch
is safe.

This data corruption affects at least the following Canon cameras: EOS 450D,
EOS 350D, EOS 50D, EOS 60D and EOS 600D. As these cameras are quite popular
many users will face this data corruption which makes rawtherapee (almost)
useless for them as keeping the EXIF information is one of the key needs for
raw converters.

See bug #693736 for all details: http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=693736

I attached the debdiff and uploaded the fixed version to mentors.debian.net:
http://mentors.debian.net/package/rawtherapee

What do you think?

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (800, 'unstable'), (150, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)

diff -Nru rawtherapee-4.0.9/debian/changelog rawtherapee-4.0.9/debian/changelog
--- rawtherapee-4.0.9/debian/changelog	2012-06-21 18:31:45.000000000 +0200
+++ rawtherapee-4.0.9/debian/changelog	2012-11-19 21:11:56.000000000 +0100
@@ -1,3 +1,11 @@
+rawtherapee (4.0.9-4) unstable; urgency=low
+
+  * Fix RC bug that corrupts EXIF data in some cases (closes: #693736):
+     - add debian/patches/03-fix_exif_corruption.patch: Use the correct
+       size for multibyte EXIF tags which use TagDirectoryTable
+
+ -- Philip Rinn <rinni@gmx.net>  Mon, 19 Nov 2012 21:11:43 +0000
+
 rawtherapee (4.0.9-3) unstable; urgency=low
 
   * Fix upgrade failure to testing (closes: #677575).
diff -Nru rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch
--- rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch	1970-01-01 01:00:00.000000000 +0100
+++ rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch	2012-11-19 19:38:27.000000000 +0100
@@ -0,0 +1,14 @@
+Author: Upstream
+Description: Use correct size on all multibyte EXIF tags which use TagDirectoryTable
+--- a/rtexif/rtexif.cc
++++ b/rtexif/rtexif.cc
+@@ -902,7 +902,7 @@
+       size += valuesize + (valuesize%2); // we align tags to even byte positions 
+ 
+    if (makerNoteKind!=NOMK) 
+-        count = directory[0]->calculateSize ();
++        count = directory[0]->calculateSize () / getTypeSize(type);
+         
+    if (makerNoteKind==NIKON3 || makerNoteKind==OLYMPUS2 || makerNoteKind==FUJI) 
+         size += valuesize;
+
diff -Nru rawtherapee-4.0.9/debian/patches/series rawtherapee-4.0.9/debian/patches/series
--- rawtherapee-4.0.9/debian/patches/series	2012-06-13 20:07:45.000000000 +0200
+++ rawtherapee-4.0.9/debian/patches/series	2012-11-19 19:37:03.000000000 +0100
@@ -1,2 +1,3 @@
 01-AboutThisBuild.patch
 02-fix_color_artifacts.patch
+03-fix_exif_corruption.patch

--- End Message ---
--- Begin Message --- 
On Mon, 2012-11-19 at 21:46 +0100, Philip Rinn wrote:
> I'd like to check the chance for unblocking before bothering my sponsor.

Apparently you now bothered your sponsor? ;-p

> A user made me consider this problem as RC today:
> RawTherapee corrupts Exif MarkerNotes for some Canon cameras. This was reported
> on upstreams bugtracker and is fixed upstream for five month now. The patch is
> only one line and fixes the bug by using the correct size for multi-byte EXIF
> tags which use TagDirectoryTable. As no problem was reported I think the patch
> is safe.

Unblocked; thanks.

Regards,

Adam

--- End Message ---
Reply to: