Bug#692122: unblock: ampache/ampache-3.6-git408e713+dfsg-3.1

[Charlie Smotherman <cjsmo@cableone.net>]

Julien, Hi

On Sun, Nov 11, 2012 at 11:30 AM, Julien Cristau <jcristau@debian.org> wrote:
> tag 692122 moreinfo
> kthxbye
>
> On Fri, Nov  2, 2012 at 02:17:00 -0500, Charlie Smotherman wrote:
>
>> diff -Nru ampache-3.6-git408e713+dfsg/debian/ampache.postrm ampache-3.6-git408e713+dfsg/debian/ampache.postrm
>> --- ampache-3.6-git408e713+dfsg/debian/ampache.postrm 2012-06-07 00:44:04.000000000 -0500
>> +++ ampache-3.6-git408e713+dfsg/debian/ampache.postrm 2012-10-14 10:13:27.000000000 -0500
>> @@ -4,24 +4,6 @@
>>
>>  . /usr/share/debconf/confmodule
>>
>> -rm_log(){
>> -     if [ -d /var/log/ampache ]; then
>> -             rm -rf /var/log/ampache
>> -     fi
>> -}
>> -
>> -rm_logr(){
>> -     if [ -f /etc/logrotate.d/ampache ]; then
>> -             rm -f /etc/logrotate.d/ampache
>> -     fi
>> -}
>> -
>> -rm_cron(){
>> -     if [ -f /etc/cron.daily/ampache ]; then
>> -             rm -f /etc/cron.daily/ampache
>> -     fi
>> -}
>> -
>
> Why is this removed entirely?  Surely you still need to clean things up
> in postrm purge?
>
>>  restart_server(){
>>       if [ -e /var/run/apache2.pid ]; then
>>               service apache2 reload
>> @@ -32,25 +14,14 @@
>>       db_get ampache/restart_webserver || true
>>       re_start="$RET"
>>       if [ "$re_start" = "false" ]; then
>> -             rm_log
>> -             rm_logr
>> -             rm_cron
>> +             printf "Please restart the web server manually."
>
> Why doesn't this have a newline?  (Why doesn't it use echo?)
>
>>       elif [ "$re_start" = "true" ]; then
>> -             rm_log
>> -             rm_logr
>> -             rm_cron
>>               restart_server
>>       else
>>               printf "unable to de-configure ampache, please do so manually.\n"
>>       fi
>>  fi
>>
>> -if [ "$1" = "purge" ]; then
>> -     if [ -d /etc/ampache ]; then
>> -             rm -rf /etc/ampache
>> -     fi
>> -fi
>> -
>
> That looks wrong.
>
>>  #DEBHELPER#
>>
>>  exit 0

Thanks for the review :)

I have been looking at ampache a bit closer and I have found some
additional bugs.  With it this late in the freeze probably the
easiest/best thing to do is to remove ampache from testing so the
release can happen.  Apache is due to transition to 2.4 post release,
which I will have to do an upload for anyway.  That should give me
enough time to make piuparts happy.

Best regard
Charlie Smotherman