Bug#691742: unblock: fs2ram/0.3.12
Hi,
Philippe Le Brouster wrote (31 Oct 2012 10:06:04 GMT) :
> Le lundi 29 octobre 2012 à 19:04 +0000, Adam D. Barratt a écrit:
>> As you mentioned above, testing currently has 0.3.10. The relevant
>> diff is thus 0.3.10 to 0.3.12, not from 0.3.11.
> Here are the information from 0.3.10 to 0.3.12 :
I'm not in the mood to review the whole thing entirely again now, but
FWIW I've upgraded to 0.3.11 as soon as it was out to fix #649179, and
at this time I had reviewed the entire 0.3.10..0.3.11 code changes
(I've been keeping an eye on this project for a while) and they
looked good.
So, in case it may be useful, here's my review for 0.3.11..0.3.12:
basically, all right, modulo the newly introduced "it is preferable to
set the variables RAMTMP, RAMLOCK from /etc/default/tmpfs" comment
that seems a bit unclear to me: I think s/from/in/ would tell me more
clearly what I should do. Probably not a blocker, though.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
Reply to: