[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692879: tpu: package rkward 0.5.7-3



Hi Thomas,

Thomas Friedrichsmeier wrote (10 Nov 2012 09:25:29 GMT) :
> For your convenience, I have also prepared a recursive diff between
> the unpacked and patched source trees of 0.5.7-2 and 0.5.7-3 ([5]).

That may be only me nitpicking, but from my humble reviewer
point-of-view:

  - a unified diff (-u) is easier to read
  - passing files to compare in the "$ORIG $NEW" order makes the
    resulting patch easier to read

> Files: rkward/qwinhost.cpp.orig rkward/qwinhost.cpp rkward/qwinhost.h.orig rkward/qwinhost.h

These paths don't look correct to me.
I suggest s,rkward/,rkward/qwinhost/,

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc


Reply to: