[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#691938: release.debian.org: unblock: parcimonie/0.7.1-1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: vagrant@debian.org

Hi,

Please unblock package parcimonie.

After being alerted of an important bug in parcimonie (#690577), with
my upstream developer hat on, I have put a bugfix-only release out.
It has been living just fine in unstable for 10 days.

Changes are:

  * 4 lines of code were changed, only to fix two bugs (#690577 and
    another one that was hiding behind the former) that make the
    parcimonie applet currently unusable in testing. These bugs are
    not RC only because the applet is not shipped in a separate binary
    package, and the CLI daemon works fine.

  * Some boring automatic boilerplate changes, such as VERSION
    variable in every module.

debdiff from testing to unstable is attached.

(FWIW, parcimonie is a leaf package with few users according to popcon
=> low risk.)

Cheers!
--
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc

diff -Nru parcimonie-0.7/bin/parcimonie parcimonie-0.7.1/bin/parcimonie
--- parcimonie-0.7/bin/parcimonie	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/bin/parcimonie	2012-10-20 12:53:02.000000000 +0200
@@ -6,7 +6,7 @@
 
 =head1 VERSION
 
-Version 0.7
+Version 0.7.1
 
 =head1 SYNOPSIS
 
@@ -134,7 +134,7 @@
 use strict;
 use warnings;
 
-our $VERSION = '0.7';
+our $VERSION = '0.7.1';
 
 use FindBin;
 use lib "$FindBin::Bin/../lib";
diff -Nru parcimonie-0.7/bin/parcimonie-applet parcimonie-0.7.1/bin/parcimonie-applet
--- parcimonie-0.7/bin/parcimonie-applet	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/bin/parcimonie-applet	2012-10-20 12:53:02.000000000 +0200
@@ -10,7 +10,7 @@
 use warnings;
 use 5.10.0;
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 use FindBin;
 use lib "$FindBin::Bin/../lib";
diff -Nru parcimonie-0.7/Build.PL parcimonie-0.7.1/Build.PL
--- parcimonie-0.7/Build.PL	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/Build.PL	2012-10-20 12:53:02.000000000 +0200
@@ -29,7 +29,7 @@
     "intrigeri <intrigeri\@boum.org>"
   ],
   "dist_name" => "App-Parcimonie",
-  "dist_version" => "0.7",
+  "dist_version" => "0.7.1",
   "license" => "perl",
   "module_name" => "App::Parcimonie",
   "recommends" => {},
diff -Nru parcimonie-0.7/Changes parcimonie-0.7.1/Changes
--- parcimonie-0.7/Changes	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/Changes	2012-10-20 12:53:02.000000000 +0200
@@ -1,5 +1,13 @@
 Revision history for App-Parcimonie
 
+0.7.1   20121020
+        Fix critical applet bugs:
+          - Use correct method name to set tooltip on status icon.
+            Thanks to Vagrant Cascadian for reporting it
+            as Debian bug #690577.
+          - Pass the -1 placeholder for text length when inserting
+            into a TextBuffer.
+
 0.7     20120623
         Migrate from Gtk2 to Gtk3:
           - Remove obsolete library import.
diff -Nru parcimonie-0.7/debian/changelog parcimonie-0.7.1/debian/changelog
--- parcimonie-0.7/debian/changelog	2012-06-23 23:33:08.000000000 +0200
+++ parcimonie-0.7.1/debian/changelog	2012-10-20 13:04:14.000000000 +0200
@@ -1,3 +1,12 @@
+parcimonie (0.7.1-1) unstable; urgency=low
+
+  * Imported Upstream version 0.7.1, that fixes critical bugs in the applet:
+    - Use correct method name to set tooltip on status icon.
+      Thanks to Vagrant Cascadian for reporting it. (Closes: #690577)
+    - Pass the -1 placeholder for text length when inserting into a TextBuffer.
+
+ -- intrigeri <intrigeri@debian.org>  Sat, 20 Oct 2012 13:01:52 +0200
+
 parcimonie (0.7-1) unstable; urgency=low
 
   * Imported Upstream version 0.7
diff -Nru parcimonie-0.7/lib/App/Parcimonie/Applet.pm parcimonie-0.7.1/lib/App/Parcimonie/Applet.pm
--- parcimonie-0.7/lib/App/Parcimonie/Applet.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie/Applet.pm	2012-10-20 12:53:02.000000000 +0200
@@ -10,7 +10,7 @@
 use Any::Moose;
 with 'App::Parcimonie::Role::HasEncoding';
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 use 5.10.0;
 use namespace::autoclean;
@@ -248,7 +248,7 @@
     my $self = shift;
     my $mesg = shift;
     my $buffer = $self->logbuffer;
-    $buffer->insert($buffer->get_end_iter, $mesg . "\n");
+    $buffer->insert($buffer->get_end_iter, $mesg . "\n", -1);
 }
 
 sub signal_fetch_begin_cb {
@@ -261,7 +261,7 @@
     );
     $self->debug($mesg);
     $self->statusicon->set_from_stock('gtk-refresh');
-    $self->statusicon->set_tooltip($mesg);
+    $self->statusicon->set_tooltip_text($mesg);
     $self->append_mesg($mesg);
     $self->statusicon->set_visible(TRUE);
 }
@@ -292,7 +292,7 @@
 
     $self->debug($mesg);
     $self->statusicon->set_from_stock($new_pixmap);
-    $self->statusicon->set_tooltip($mesg);
+    $self->statusicon->set_tooltip_text($mesg);
     $self->append_mesg($mesg);
     $self->statusicon->set_visible(TRUE);
     Glib::Timeout->add(
@@ -304,7 +304,7 @@
 sub now_resting {
     my $self = shift;
     $self->statusicon->set_from_stock('gtk-media-pause');
-    $self->statusicon->set_tooltip($self->encoding->decode(
+    $self->statusicon->set_tooltip_text($self->encoding->decode(
         gettext('Having a rest.')
     ));
     $self->statusicon->set_visible(TRUE);
diff -Nru parcimonie-0.7/lib/App/Parcimonie/Daemon.pm parcimonie-0.7.1/lib/App/Parcimonie/Daemon.pm
--- parcimonie-0.7/lib/App/Parcimonie/Daemon.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie/Daemon.pm	2012-10-20 12:53:02.000000000 +0200
@@ -11,7 +11,7 @@
 package App::Parcimonie::Daemon;
 use Any::Moose;
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 with 'App::Parcimonie::Role::HasEncoding';
 with any_moose('X::Getopt::Dashes');
diff -Nru parcimonie-0.7/lib/App/Parcimonie/DBus/Object.pm parcimonie-0.7.1/lib/App/Parcimonie/DBus/Object.pm
--- parcimonie-0.7/lib/App/Parcimonie/DBus/Object.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie/DBus/Object.pm	2012-10-20 12:53:02.000000000 +0200
@@ -9,7 +9,7 @@
 use strict;
 use warnings;
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 # We're going to be a DBus object
 use base qw{Net::DBus::Object};
diff -Nru parcimonie-0.7/lib/App/Parcimonie/GnuPG/Interface.pm parcimonie-0.7.1/lib/App/Parcimonie/GnuPG/Interface.pm
--- parcimonie-0.7/lib/App/Parcimonie/GnuPG/Interface.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie/GnuPG/Interface.pm	2012-10-20 12:53:02.000000000 +0200
@@ -12,7 +12,7 @@
 use Any::Moose;
 extends 'GnuPG::Interface';
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 use namespace::autoclean;
 use Carp;
diff -Nru parcimonie-0.7/lib/App/Parcimonie/Role/HasCodeset.pm parcimonie-0.7.1/lib/App/Parcimonie/Role/HasCodeset.pm
--- parcimonie-0.7/lib/App/Parcimonie/Role/HasCodeset.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie/Role/HasCodeset.pm	2012-10-20 12:53:02.000000000 +0200
@@ -16,7 +16,7 @@
 package App::Parcimonie::Role::HasCodeset;
 use Any::Moose 'Role';
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 use namespace::autoclean;
 use Try::Tiny;
diff -Nru parcimonie-0.7/lib/App/Parcimonie/Role/HasEncoding.pm parcimonie-0.7.1/lib/App/Parcimonie/Role/HasEncoding.pm
--- parcimonie-0.7/lib/App/Parcimonie/Role/HasEncoding.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie/Role/HasEncoding.pm	2012-10-20 12:53:02.000000000 +0200
@@ -16,7 +16,7 @@
 package App::Parcimonie::Role::HasEncoding;
 use Any::Moose 'Role';
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 use namespace::autoclean;
 with 'App::Parcimonie::Role::HasCodeset';
diff -Nru parcimonie-0.7/lib/App/Parcimonie.pm parcimonie-0.7.1/lib/App/Parcimonie.pm
--- parcimonie-0.7/lib/App/Parcimonie.pm	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/lib/App/Parcimonie.pm	2012-10-20 12:53:02.000000000 +0200
@@ -3,7 +3,7 @@
 use warnings;
 use strict;
 
-our $VERSION = '0.7'; # VERSION
+our $VERSION = '0.7.1'; # VERSION
 
 use App::Parcimonie::GnuPG::Interface;
 use Carp;
diff -Nru parcimonie-0.7/META.json parcimonie-0.7.1/META.json
--- parcimonie-0.7/META.json	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/META.json	2012-10-20 12:53:02.000000000 +0200
@@ -4,7 +4,7 @@
       "intrigeri <intrigeri@boum.org>"
    ],
    "dynamic_config" : 0,
-   "generated_by" : "Dist::Zilla version 4.300018, CPAN::Meta::Converter version 2.120921",
+   "generated_by" : "Dist::Zilla version 4.300020, CPAN::Meta::Converter version 2.120921",
    "license" : [
       "perl_5"
    ],
@@ -80,6 +80,6 @@
          "url" : "git://gaffer.ptitcanardnoir.org/App-Parcimonie.git"
       }
    },
-   "version" : "0.7"
+   "version" : "0.7.1"
 }
 
diff -Nru parcimonie-0.7/META.yml parcimonie-0.7.1/META.yml
--- parcimonie-0.7/META.yml	2012-06-23 23:25:38.000000000 +0200
+++ parcimonie-0.7.1/META.yml	2012-10-20 12:53:02.000000000 +0200
@@ -19,7 +19,7 @@
 configure_requires:
   Module::Build: 0.3601
 dynamic_config: 0
-generated_by: 'Dist::Zilla version 4.300018, CPAN::Meta::Converter version 2.120921'
+generated_by: 'Dist::Zilla version 4.300020, CPAN::Meta::Converter version 2.120921'
 license: perl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -55,4 +55,4 @@
 resources:
   homepage: https://gaffer.ptitcanardnoir.org/intrigeri/code/parcimonie/
   repository: git://gaffer.ptitcanardnoir.org/App-Parcimonie.git
-version: 0.7
+version: 0.7.1

Reply to: