[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689154: unblock: gnunet/0.9.3-4



Control: unblock 687875 by 689154
Control: unblock 687881 by 689154
Control: unblock 687883 by 689154
Control: unblock 688486 by 689154
Control: unblock 688590 by 689154
Control: unblock 686238 by 689154
Control: unblock 684997 by 689154
Control: unblock 688484 by 689154
Control: unblock 690860 by 689154
Control: unblock 684317 by 689154
The release team is not preventing you to fix those bugs in the archive
(starting with sid or experimental), so removing those useless blocks.

Hi,

Le 18/10/2012 16:32, Bertrand Marc a écrit :
> Le 13/10/2012 18:27, Adam D. Barratt a écrit :
>> + * Revert the use dh_installdocs --link-doc (Closes: #687875, #687881,
>> + #687883).
>>
>> What happens if a user has the broken version installed already and then
>> upgrades to -4? As far as I can tell, nothing in the new diff helps
>> resolve the issues which have already occurred, as opposed to stopping
>> them recurring.
> 
> You're right, nothing helps resolve the issues which have already occurred.
> It can only happen on new installation of gnunet on testing during the last
> 6 months though, so upgrades from Squeeze will go smoothly. And the issue
> can be easily fixed by reinstalling gnunet.

Reinstalling won't work. One will need to remove the package, and
install it again. Why don't you simply fix those new bugs with a bunch
of .preinst script (or keep the symlinks, and fix the upgrade from
Squeeze in a bunch of .postinst scripts)?


For each PACKAGE in gnunet-dev gnunet-server gnunet-dbg gnunet-client
gnunet, you could either add the following preinst (just replace PACKAGE):

-------------- PACKAGE.preinst ---------------

#! /bin/sh
set -e

# Delete symlink that will be replaced by a directory
docdir="/usr/share/doc/PACKAGE"
if [ -L $docdir ]; then
    rm doc$dir 2>/dev/null
fi

#DEBHELPER#

exit 0

-----------------------------------------------


or rather keep the symlinks, and add the five following postinst (just
replace PACKAGE):

-------------- PACKAGE.postinst ---------------

#!/bin/sh
set -e

# Replace documentation directory with symlink
docdir="/usr/share/doc/PACKAGE"
if [ -d $docdir ] && [ ! -L $docdir ]; then
    if rmdir $docdir 2>/dev/null; then
        ln -sf gnunet-common $docdir
    fi
fi

#DEBHELPER#

exit 0

-----------------------------------------------


I noticed a charset mess while testing your package in a French
localized environment, and just pushed another tiny change in your Git
repository. It complies with the forth point of the Wheezy Freeze Policy
(“translation […] fixes”) [0].

	0: http://release.debian.org/wheezy/freeze_policy.html

Regards

David

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: