[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#691877: marked as done (unblock: libbusiness-onlinepayment-ippay-perl/0.06-2)



Your message dated Tue, 30 Oct 2012 19:33:35 +0000
with message-id <1351625615.16094.12.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#691877: unblock: libbusiness-onlinepayment-ippay-perl/0.06-2
has caused the Debian Bug report #691877,
regarding unblock: libbusiness-onlinepayment-ippay-perl/0.06-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
691877: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691877
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Please unblock package libbusiness-onlinepayment-ippay-perl 0.06-2

This adds a backported patch to fix #691723.

The patch changes the IPPay gateway's server name and path.

(Note that the changes in the tests are not strictly necessary since
they are skipped on Debian but I decided to keep them, in case
someone wants to run them themselves.)

Debdiff attached.

unblock libbusiness-onlinepayment-ippay-perl/0.06-2

(Request concerning s-p-u following shortly.)

Thanks in advance,
gregor

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQkAnXAAoJELs6aAGGSaoGsRMP/RKZVDFHOEV6Tv9YfRVwWE26
9JrU3CvLZw/RkE3obVIzwau4IuzsEUFZ03gYbld2Pik07VR9np6+NxBLyMrTxCWn
VveTeNPUQxLmFQ8Cq6Ry0Cs23acspCJiiCNj97BK7xRy8f8tZAYVpCnhojk56bSA
GLPIe1F84d/lmw9muTBw6j3BWD6SzJjBCK40DidOUqeGeZQ4shdnwzRoh7jKA5eX
QE62aFebK9p9ollTdAedo4kj8W/i53p1oASDZCws7g8ZkENhD+KbYsryL8Bb1+EV
wkNr2hs3EIhGMTuduuyzYKn+9EsWiBD0fc6wso6i76oMmtNJs8rdkudrUR2NS7kM
te8G9RbedB600UePCOgjmrS6aQvldPB6Kn/IMgeiua2Q70XlZAhp63WPSA2g3U2K
7yQhTkG1UCpbq2yYANqvybUHZIdiDtgIKohcVbH2K+1mCdZfssyhsSkRpGfaWxAh
dGj3eQ3gzJOyFSewU2FVvkW/WAZtRpmEE/ngg3WoY9lwlPnlDwG7EAPc949lLPh0
OvBGcAxNyVGNcQRvm+lxRvWhw5VB4R7eV6iWXaxGjE6RiTtqsNupZj0iM7W+/lgh
AUxieSFPBhGVQJmNsO3P74zxj6C/3fBBgxbSZVWINowdrB9y0KiW+lIlIot7suIS
TxldUpldj1cyAs1461jZ
=p5ic
-----END PGP SIGNATURE-----
diff --git a/debian/changelog b/debian/changelog
index 625531c..1bd6ae3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+libbusiness-onlinepayment-ippay-perl (0.06-2) unstable; urgency=low
+
+  * Team upload.
+  * New patch gateway.patch: change IPPay gateway server/path. Thanks to
+    Ivan Kohler for backporting the patch. (Closes: #691723)
+
+ -- gregor herrmann <gregoa@debian.org>  Tue, 30 Oct 2012 17:59:17 +0100
+
 libbusiness-onlinepayment-ippay-perl (0.06-1) unstable; urgency=low
 
   [ Nicholas Bamber ]
diff --git a/debian/patches/gateway.patch b/debian/patches/gateway.patch
new file mode 100644
index 0000000..c47bd71
--- /dev/null
+++ b/debian/patches/gateway.patch
@@ -0,0 +1,89 @@
+Description: IPPay changed the gateway's server name and path, and will soon
+ turn off the old gateway
+Origin: https://www.freeside.biz/gitweb/?p=Business-OnlinePayment-IPPay.git;a=commitdiff;h=1f19e67636476c7119cfb41920c5b176e617c697
+Bug-Debian: #691723
+Author: Ivan Kohler <ivan-debian@420.am>
+Reviewed-by: gregor herrmann <gregoa@debian.org>
+Last-Update: 2012-10-30
+Applied-Upstream: yes, 0.07
+
+--- a/IPPay.pm
++++ b/IPPay.pm
+@@ -45,9 +45,9 @@
+     my %opts = @_;
+ 
+     # standard B::OP methods/data
+-    $self->server('gateway17.jetpay.com') unless $self->server;
++    $self->server('gtwy.ippay.com') unless $self->server;
+     $self->port('443') unless $self->port;
+-    $self->path('/jetpay') unless $self->path;
++    $self->path('/ippay') unless $self->path;
+ 
+     $self->build_subs(qw( order_number avs_code cvv2_response
+                           response_page response_code response_headers
+@@ -209,6 +209,9 @@
+   foreach ( keys ( %{($self->{_defaults})} ) ) {
+     $content{$_} = $self->{_defaults}->{$_} unless exists($content{$_});
+   }
++  if ($self->test_transaction()) {
++    $content{'login'} = 'TESTTERMINAL';
++  }
+   $self->content(%content);
+ 
+   $self->required_fields(@required_fields);
+@@ -221,12 +224,6 @@
+     }
+   }
+ 
+-  if ($self->test_transaction()) {
+-    $self->server('test1.jetpay.com');
+-    $self->port('443');
+-    $self->path('/jetpay');
+-  }
+-
+   my $transaction_id = $content{'order_number'};
+   unless ($transaction_id) {
+     my ($page, $server_response, %headers) = $self->https_get('dummy' => 1);
+@@ -391,7 +388,7 @@
+     if (  exists($response->{ActionCode}) && !exists($response->{ErrMsg})) {
+       $self->error_message($response->{ResponseText});
+     }else{
+-      $self->error_message($response->{Errmsg});
++      $self->error_message($response->{ErrMsg});
+     }
+ #  }else{
+ #    $self->error_message("Server Failed");
+@@ -588,6 +585,9 @@
+ 
+ =head1 COMPATIBILITY
+ 
++Debian version 0.06-2 (upstream version 0.07) changes the server name and path
++for IPPay's late 2012 update.
++
+ Business::OnlinePayment::IPPay uses IPPay XML Product Specifications version
+ 1.1.2.
+ 
+--- a/t/card.t
++++ b/t/card.t
+@@ -61,8 +61,8 @@
+     $tx,
+     desc          => "invalid card_number",
+     is_success    => 0,
+-    result_code   => '912',
+-    error_message => 'INVALID CARD NUMBER',
++    result_code   => '900', #'912' with old jetpay gw
++    error_message => 'Invalid card number.  ', #'INVALID CARD NUMBER' w/old gw
+     authorization => qr/^$/,
+     avs_code      => '',           # so rather pointless :\
+     cvv2_response => '',           # ...
+--- a/t/lib/test_account.pl
++++ b/t/lib/test_account.pl
+@@ -12,7 +12,7 @@
+ sub test_account {
+     my $suffix = shift || 'card';
+ 
+-    my($login, $password) = ('TESTMERCHANT', '');
++    my($login, $password) = ('TESTTERMINAL', '');
+ 
+     my %opt;
+     if ( $suffix eq 'check ' ) {
diff --git a/debian/patches/series b/debian/patches/series
index 9fe8b1a..a5dd937 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 no-connectivity.patch
+gateway.patch

--- End Message ---
--- Begin Message ---
On Tue, 2012-10-30 at 18:09 +0100, gregor herrmann wrote:
> Please unblock package libbusiness-onlinepayment-ippay-perl 0.06-2
> 
> This adds a backported patch to fix #691723.
> 
> The patch changes the IPPay gateway's server name and path.

Unblocked; thanks.

Regards,

Adam

--- End Message ---

Reply to: