[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689691: unblock: php-letodms-core/3.3.9-1



reopen 689691


Hi,
I comment bellow,

El dom, 14-10-2012 a las 09:08 +0200, Niels Thykier escribió:
> On 2012-10-08 17:37, Francisco Manuel Garcia Claramonte wrote:
> > 
> > I have prepared a diff file from my GIT Debian development copy 
> > (just local copy). It shows all changes from 3.3.4-1 to 3.3.9-1 
> > [1].
> > 
> > I have prepared another diff file with main changes, removed some
> > unneeded diffs (in files as example), to easy review [2].
> > 
> > And a full debdiff [3] file. Much harder to review.
> > 
> > Please tell me if you need anything else, or I can help you in some
> > way.
> > 
> > 
> > [1] 
> > http://people.debian.org/~francisco/letodms/php-letodms-core_3.3.4--3.3.9.git.diff
> >
> >  [2] 
> > http://people.debian.org/~francisco/letodms/php-letodms-core_3.3.4--3.3.9.git-main_changes.diff
> >
> >  [3] 
> > http://people.debian.org/~francisco/letodms/php-letodms-core_3.3.4--3.3.9.debdiff
> >
> > 
> 
> [1] and [2] where much much better than the full debdiff [3].
> 



We found a bug in PHP source, I have patched the source package
and upload to unstable.
Attach the debdiff with the changes (very simple to review).

Please, Could you unblock php-letodms-3.3.9-2.

Thank you for your support.

Regards,
Francis


> Unblocked, thanks.
> 
> ~Niels
> 

-- 
Francisco M. García Claramonte 
Debian GNU/Linux Developer <francisco@debian.org>    
GPG: public key ID 556ABA51
http://people.debian.org/~francisco/

diffstat for php-letodms-core-3.3.9 php-letodms-core-3.3.9

 changelog                        |    6 ++++++
 patches/fix_classDMS_method.diff |   11 +++++++++++
 patches/series                   |    1 +
 3 files changed, 18 insertions(+)

diff -Nru php-letodms-core-3.3.9/debian/changelog php-letodms-core-3.3.9/debian/changelog
--- php-letodms-core-3.3.9/debian/changelog	2012-09-20 11:58:11.000000000 +0200
+++ php-letodms-core-3.3.9/debian/changelog	2012-10-18 12:01:23.000000000 +0200
@@ -1,3 +1,9 @@
+php-letodms-core (3.3.9-2) unstable; urgency=low
+
+  * Added debian patch fix_classDMS_method to fix a PHP source bug.
+
+ -- Francisco Manuel Garcia Claramonte <francisco@debian.org>  Thu, 18 Oct 2012 11:26:00 +0200
+
 php-letodms-core (3.3.9-1) unstable; urgency=low
 
   * New upstream release (More security fixes for preventing CSRF, XSS and sql
diff -Nru php-letodms-core-3.3.9/debian/patches/fix_classDMS_method.diff php-letodms-core-3.3.9/debian/patches/fix_classDMS_method.diff
--- php-letodms-core-3.3.9/debian/patches/fix_classDMS_method.diff	1970-01-01 01:00:00.000000000 +0100
+++ php-letodms-core-3.3.9/debian/patches/fix_classDMS_method.diff	2012-10-18 11:21:52.000000000 +0200
@@ -0,0 +1,11 @@
+--- a/LetoDMS_Core-3.3.9/Core/inc.ClassDMS.php
++++ b/LetoDMS_Core-3.3.9/Core/inc.ClassDMS.php
+@@ -1139,7 +1139,7 @@
+ 		if (is_object($this->getDocumentCategoryByName($name))) {
+ 			return false;
+ 		}
+-		$queryStr = "INSERT INTO tblCategory (name) VALUES (".$this->db-qstr($name).")";
++		$queryStr = "INSERT INTO tblCategory (name) VALUES (".$this->db->qstr($name).")";
+ 		if (!$this->db->getResult($queryStr))
+ 			return false;
+ 
diff -Nru php-letodms-core-3.3.9/debian/patches/series php-letodms-core-3.3.9/debian/patches/series
--- php-letodms-core-3.3.9/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ php-letodms-core-3.3.9/debian/patches/series	2012-10-18 11:20:23.000000000 +0200
@@ -0,0 +1 @@
+fix_classDMS_method.diff

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: