[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683730: unblock: cups/1.5.3-2+wheezy0



Hi Didier,

a couple comments/questions...

On Fri, Aug  3, 2012 at 12:58:06 +0200, Didier Raboud wrote:

> === modified file 'debian/cups.postinst'
> --- old/debian/cups.postinst	2012-05-23 12:31:13 +0000
> +++ new/debian/cups.postinst	2012-08-02 16:37:24 +0000
> @@ -79,9 +79,14 @@
>      db_get cupsys/backend && SELECTED=$RET
>      # We remove the scsi backend from the output as it got removed in CUPS 1.5.0
>      list=`echo $SELECTED | sed -e 's/, /,/g' | sed -e 's/scsi,*//g' | sed -e 's/parallel,*//g' | sed -e 's/serial,*//g'`
> +    if dpkg --compare-versions "$2" lt-nl "1.5.3-2+wheezy0"; then
> +	if ! echo $list | grep -q "\bipp14\b"; then
> +	    list=`echo $list | sed -e 's/\bipp\b/ipp,ipp14/g'`
> +	fi
> +    fi
>      save_IFS=$IFS
>      IFS=,
> -    (cd /usr/lib/cups/backend && rm -f http https ipp ipps lpd socket usb snmp dnssd mdns)
> +    (cd /usr/lib/cups/backend && rm -f http https ipp ipp14 ipps lpd socket usb snmp dnssd mdns)
>      for module in $list; do
>        ln /usr/lib/cups/backend-available/$module /usr/lib/cups/backend/$module
>        if [ "$module" = "ipp" ]; then
> @@ -99,7 +104,7 @@
>      db_fset cupsys/backend changed false
>  
>      # Resync Debconf database with real state
> -    list=`( cd /usr/lib/cups/backend && for f in ipp lpd socket usb snmp dnssd; do [ -e $f ] && echo -n "$f, "; done ) | sed -e 's/, $//'`
> +    list=`( cd /usr/lib/cups/backend && for f in ipp ipp14 lpd socket usb snmp dnssd; do [ -e $f ] && echo -n "$f, "; done ) | sed -e 's/, $//'`
>      db_set cupsys/backend $list;
>  
>      if [ -f /etc/cups/classes.conf ]; then
> 
> === modified file 'debian/cups.prerm'
> --- old/debian/cups.prerm	2012-02-06 21:45:21 +0000
> +++ new/debian/cups.prerm	2012-08-02 16:37:24 +0000
> @@ -19,7 +19,7 @@
>  
>  case "$1" in
>      remove)
> -	(cd /usr/lib/cups/backend && rm -f http https ipp ipps lpd socket usb snmp dnssd mdns)
> +	(cd /usr/lib/cups/backend && rm -f http https ipp ipp14 ipps lpd socket usb snmp dnssd mdns)
>          ;;
>      upgrade|deconfigure)
>          ;;
> 

this whole stuff smells like insanity but I guess it's no worse than it
used to be

[...]
> 
> === modified file 'debian/cups.postinst'
> --- old/debian/cups.postinst	2012-08-02 16:37:24 +0000
> +++ new/debian/cups.postinst	2012-08-03 10:09:05 +0000
> @@ -175,8 +175,8 @@
>  	fi
>      fi
>  
> -    if dpkg --compare-versions "$2" lt "1.5.3"; then
> -	rmmod usblp || :
> +    if dpkg --compare-versions "$2" lt "1.5.3-2+wheezy0"; then
> +        modprobe usblp >/dev/null 2>&1 || :
>      fi
>  fi
>  
> 
1) why?
2) if modprobe needs to be there shouldn't it rather be modprobe -b?

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: