[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#690003: marked as done (unblock: libgda5/5.0.3-2)

Your message dated Mon, 08 Oct 2012 22:38:33 +0100
with message-id <1349732313.11774.38.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#690003: unblock: libgda5/5.0.3-2
has caused the Debian Bug report #690003,
regarding unblock: libgda5/5.0.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
690003: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690003
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package libgda5

The sqlite provider in libgda-5.0-4 uses dlopen() to load the sqlite3
library. As a result, libgda-5.0-4 did not have a dependency on
libsqlite3-0  so it was not guaranteed that libsqlite3-0 was actually
installed when applications, like anjuta, were using the sqlite provider.
In case of anjuta this lead to crashes when trying to open or create new
projects.
As a workaround, we now link the sqlite provider against sqlite3, so we
get a proper shlibs dependency.

Full debdiff is attached.

Thanks KiBi for the patch!

Cheers,
Michael


unblock libgda5/5.0.3-2

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru libgda5-5.0.3/debian/changelog libgda5-5.0.3/debian/changelog
--- libgda5-5.0.3/debian/changelog	2012-02-10 13:43:52.000000000 +0100
+++ libgda5-5.0.3/debian/changelog	2012-10-08 21:52:13.000000000 +0200
@@ -1,3 +1,14 @@
+libgda5 (5.0.3-2) unstable; urgency=low
+
+  [ Cyril Brulebois ]
+  * Link the sqlite provider against sqlite3 (Closes: #667751).
+
+  [ Michael Biebl ]
+  * Use dh-autoreconf to update the build system.
+  * Drop explicit Build-Depends on gir1.2-freedesktop and gir1.2-glib-2.0.
+
+ -- Michael Biebl <biebl@debian.org>  Mon, 08 Oct 2012 21:52:11 +0200
+
 libgda5 (5.0.3-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru libgda5-5.0.3/debian/control libgda5-5.0.3/debian/control
--- libgda5-5.0.3/debian/control	2012-02-10 13:45:44.000000000 +0100
+++ libgda5-5.0.3/debian/control	2012-10-08 22:02:01.000000000 +0200
@@ -10,6 +10,8 @@
                gnome-pkg-tools (>= 0.11),
                intltool,
                pkg-config (>= 0.18),
+               dh-autoreconf,
+               gnome-doc-utils,
                libjson-glib-dev,
                libglib2.0-dev (>= 2.28.0),
                libsqlite3-dev (>= 3.6.11),
@@ -22,8 +24,6 @@
                libsoup2.4-dev,
                gobject-introspection (>= 0.10.0),
                libgirepository1.0-dev (>= 0.10.0),
-               gir1.2-freedesktop,
-               gir1.2-glib-2.0,
                gtk-doc-tools,
                python (>= 2.6.6-3~)
 Build-Depends-Indep: libglib2.0-doc
diff -Nru libgda5-5.0.3/debian/control.in libgda5-5.0.3/debian/control.in
--- libgda5-5.0.3/debian/control.in	2012-01-04 02:15:52.000000000 +0100
+++ libgda5-5.0.3/debian/control.in	2012-10-08 21:50:59.000000000 +0200
@@ -10,6 +10,8 @@
                gnome-pkg-tools (>= 0.11),
                intltool,
                pkg-config (>= 0.18),
+               dh-autoreconf,
+               gnome-doc-utils,
                libjson-glib-dev,
                libglib2.0-dev (>= 2.28.0),
                libsqlite3-dev (>= 3.6.11),
@@ -22,8 +24,6 @@
                libsoup2.4-dev,
                gobject-introspection (>= 0.10.0),
                libgirepository1.0-dev (>= 0.10.0),
-               gir1.2-freedesktop,
-               gir1.2-glib-2.0,
                gtk-doc-tools,
                python (>= 2.6.6-3~)
 Build-Depends-Indep: libglib2.0-doc
diff -Nru libgda5-5.0.3/debian/patches/01-link-sqlite-provider-against-sqlite3.patch libgda5-5.0.3/debian/patches/01-link-sqlite-provider-against-sqlite3.patch
--- libgda5-5.0.3/debian/patches/01-link-sqlite-provider-against-sqlite3.patch	1970-01-01 01:00:00.000000000 +0100
+++ libgda5-5.0.3/debian/patches/01-link-sqlite-provider-against-sqlite3.patch	2012-10-08 21:41:09.000000000 +0200
@@ -0,0 +1,17 @@
+Description: Link sqlite provider against sqlite3
+ The sqlite provider uses dlopen() to load the sqlite3 library.
+ As a consequence, libgda-5.0-4 did not have a dependency on libsqlite3-0
+ so it was not guaranteed that libsqlite3-0 was actually installed when
+ applications, like anjuta, were using the sqlite provider.
+Author: Cyril Brulebois <kibi@debian.org>
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=667751
+--- libgda5-5.0.3.orig/providers/sqlite/Makefile.am
++++ libgda5-5.0.3/providers/sqlite/Makefile.am
+@@ -18,6 +18,7 @@ libgda_sqlite_la_SOURCES = \
+ libgda_sqlite_la_LDFLAGS = -export-dynamic -module -avoid-version $(NO_UNDEFINED) $(LIBTOOL_PROV_EXPORT_OPTIONS)
+ libgda_sqlite_la_LIBADD = \
+ 	$(top_builddir)/libgda/libgda-5.0.la \
++	$(SQLITE_LIBS) \
+ 	$(COREDEPS_LIBS)
+ 
+ xmldir   = $(datadir)/libgda-5.0
diff -Nru libgda5-5.0.3/debian/patches/series libgda5-5.0.3/debian/patches/series
--- libgda5-5.0.3/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libgda5-5.0.3/debian/patches/series	2012-10-08 21:33:25.000000000 +0200
@@ -0,0 +1 @@
+01-link-sqlite-provider-against-sqlite3.patch
diff -Nru libgda5-5.0.3/debian/rules libgda5-5.0.3/debian/rules
--- libgda5-5.0.3/debian/rules	2012-02-10 09:24:17.000000000 +0100
+++ libgda5-5.0.3/debian/rules	2012-10-08 21:41:28.000000000 +0200
@@ -5,6 +5,7 @@
 include /usr/share/gnome-pkg-tools/1/rules/uploaders.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/rules/utils.mk
+include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/class/gnome.mk
 -include /usr/share/gnome-pkg-tools/1/rules/gnome-get-source.mk

--- End Message ---
--- Begin Message --- 
On Mon, 2012-10-08 at 23:21 +0200, Michael Biebl wrote:
> The sqlite provider in libgda-5.0-4 uses dlopen() to load the sqlite3
> library. As a result, libgda-5.0-4 did not have a dependency on
> libsqlite3-0  so it was not guaranteed that libsqlite3-0 was actually
> installed when applications, like anjuta, were using the sqlite provider.
> In case of anjuta this lead to crashes when trying to open or create new
> projects.
> As a workaround, we now link the sqlite provider against sqlite3, so we
> get a proper shlibs dependency.

Unblocked; thanks.

Regards,

Adam

--- End Message ---
Reply to: