[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689770: marked as done (pre-unblock: fbreader/0.12.10dfsg-8)

Your message dated Mon, 08 Oct 2012 22:01:51 +0200
with message-id <5073312F.7020002@thykier.net>
and subject line Re: Bug#689770: pre-unblock: fbreader/0.12.10dfsg-8
has caused the Debian Bug report #689770,
regarding pre-unblock: fbreader/0.12.10dfsg-8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
689770: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689770
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please pre-approve the attached patch for the package fbreader.

See the background at #689338 and [1].


[1] https://github.com/geometer/FBReader/issues/224

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-2-686-pae (SMP w/2 CPU cores)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff --git a/zlibrary/core/src/filesystem/ZLInputStreamDecorator.cpp b/zlibrary/core/src/filesystem/ZLInputStreamDecorator.cpp
index b44cf9a..b0b65b9 100644
--- a/zlibrary/core/src/filesystem/ZLInputStreamDecorator.cpp
+++ b/zlibrary/core/src/filesystem/ZLInputStreamDecorator.cpp
@@ -24,7 +24,10 @@ ZLInputStreamDecorator::ZLInputStreamDecorator(shared_ptr<ZLInputStream> decorat
 
 bool ZLInputStreamDecorator::open() {
 	bool result = myBaseStream->open();
-	myBaseOffset = myBaseStream->offset();
+	if (result)
+	{
+		myBaseOffset = myBaseStream->offset();
+	}
 	return result;
 }

--- End Message ---
--- Begin Message --- 
On 2012-10-08 18:19, Eugene V. Lyubimkin wrote:
> Hi,
> 
> On 2012-10-06 10:29, Niels Thykier wrote:
>> Looks reasonable, please go ahead.  Please ping us once the patched
>> fbreader has been in sid for a couple of days.
> 
> Thanks and ping. 
> 

Unblocked, thanks.

~Niels

--- End Message ---
Reply to: