On Sun, Oct 7, 2012 at 5:44 PM, Mehdi Dogguy
<mehdi@dogguy.org> wrote:
Looking at the provided diff, I've found for example:
+#ifdef ZEND_ENGINE_2_4
+ case IS_CALLABLE:
+ /* XXX implement this */
+ assert(0);
+ break;
+#endif
I'd rather avoid it.
I'm not a C programmer so I can't comment on that otherwise than this is also the default for the switch (looks a few line bellow that section in apc_compile.c).
default:
assert(0);
So basically this only adds support for a new object type changed in PHP 5.4 (due to changes in Closures and addition of Traits, AFAIK).
Moreover, most changes are put under an "#ifdef ZEND_ENGINE_2_4" while
php5-dev (afaics) defines ZEND_ENGINE_2. So, as far as I can tell, this
release won't add much for Debian. (Please tell me if I got something
wrong). Based on that, I'd prefer to keep current wheezy's version
unchanged.
Instead of accepting php-apc/3.1.13-1, did you want to include targeted
fixes in Wheezy? If not, I think I'd close this bugreport.
Nope, I want to include 3.1.13, as it offers better PHP 5.4 support. I don't want people to encounter all the memory leaks and crashes fixed since the initial PHP 5.4 support for APC ( = version 3.1.10). See