[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#688865: unblock: apt/

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: deity@lists.debian.org

Please unblock package apt

The diff between and is
(minus translation updates and testcases):

 apt-pkg/algorithms.cc        |    5 +++++
 apt-pkg/aptconfiguration.cc  |   11 +++++++++++
 apt-pkg/aptconfiguration.h   |    8 ++++++++
 apt-pkg/cdrom.cc             |   34 +++++++++++++++++++++++++++++++---
 apt-pkg/cdrom.h              |    1 +
 apt-pkg/deb/deblistparser.cc |   22 ++++++++++++++++++----
 apt-pkg/deb/dpkgpm.cc        |   10 +++++++---
 apt-pkg/indexcopy.cc         |   26 ++++++++++++++++----------
 apt-pkg/packagemanager.cc    |    9 +++++++--
 apt-pkg/pkgcache.cc          |    6 +++++-
 apt-pkg/pkgcachegen.cc       |   55
 debian/control               |    1 +
 doc/apt_preferences.5.xml    |   10 +++++-----
 13 files changed, 169 insertions(+), 29 deletions(-)

(Attached is the diff + testcases, but still - translations)

Sorry for being so late, I thought I had sent this already…
Anyway: As this version changes apt-cdrom behavior a bit for d-i
you still might want to consider it for the d-i beta3 release images.

And now as usual some additional comments for the changes made:

>  * handle packages without a mandatory architecture (debian-policy §5.3)
>    by introducing a pseudo-architecture 'none' so that the small group of
>    users with these packages can get right of them without introducing too
>    much hassle for other users (Closes: #686346)
>  * apt-pkg/pkgcachegen.cc:
>    - do not create 'native' (or now 'none') package structures as a side
>      effect of description translation parsing as it pollutes the cache

On older system it's possible that you have still packages without an
architecture installed. Previously such a package satisfied dependencies
from other packages (with an arch), now dpkg prints a warning and handles
arch-less packages as a different architecture, so these dependencies aren't
satisfied anymore -- which means that your system quiet likely is broken
and you just don't know it because nobody has told you so.

This change allows APT to continue to work in such an environment,
meaning that it tells the user that the system is broken and can fix
it in the usual way (apt-get install -f). The net-result should be that the
release-notes recommend each user to get right of these packages after the
installation of wheezy with: "apt-get remove .*:none" and be done with it.

It should be noted that we have a silly bug here possibly causing APT to claim
that the system is less broken than it actually is, but the fix is one-line
and doesn't effect the previously mentioned :none extermination usecase, so we
would prefer to get into wheezy anyhow and fix that in later.

> * apt-pkg/cdrom.cc:
>   - copy only configured translation files from a CD-ROM and not all
>     available translation files preventing new installs with d-i from
>     being initialized with all translations (Closes: #678227)

Discussed at length in the bugreport as well as on d-release@l.d.o.
In short: It is a behavior change, but the biggest user (d-i) actually
expects this behavior.

>   - handle Components in the reduction for the source.list as multi-arch CDs
>     otherwise create duplicated source entries (e.g. "wheezy main main")
> * apt-pkg/indexcopy.cc:
>   - do not create duplicated flat-archive CD-ROM sources for foreign
>     architectures on multi-arch CD-ROMs

I am kinda shocked that nobody complained about that after installing from
a multi-arch CD, but I guess most of the people testing multi-arch CDs now
have a strong internet-connection and therefore disable cdrom sources --
or ignore "strange" entries and/or warnings.

>   - do not warn about files which have a record in the Release file, but
>     are not present on the CD to mirror the behavior of the other methods
>     and to allow uncompressed indexes to be dropped without scaring users

Needed to support jessie-CDs -- assuming that apt-ftparchive/wheezy is
used to create them as these will include e.g. uncompressed Translation-*
files in the Release file which don't end up on the CD. This was an error at
some point and demoted to a warning some time ago for ubuntu which dropped
uncompressed indexes all-together from the CD. It's just that the warning
serves no propose, beside possible puzzling users -- so it is now demoted
to a debug message which makes more sense.

> * apt-pkg/packagemanager.cc:
>   - unpack versions only in case a different version from the package
>     is currently in unpack state to recover from broken system states
>     (like different file in M-A:same package and other dpkg errors)
>     and avoid re-unpack otherwise (Closes: #670900)
> * debian/control:
>   - let libapt-pkg break apt < 0.9.4 to ensure that the installed http-
>     method supports the new redirection-style, thanks to Raphael Geissert
>     for reporting & testing (Closes: #685192)
> * doc/apt_preferences.5.xml:
>   - use the correct interval (x <= P < y) for pin value documentation as
>     these are the intervals used by the code (Closes: #685989)

(No further comments for those.)

As I already hinted, there will be a upload after this one which
is hopefully considerably smaller in diff-size.
Still, sorry for the constant "noise" from us …

unblock apt/

Thanks for your work & best regards

David Kalnischkies

Attachment: apt-unblock-
Description: Binary data

Reply to: