[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Patch for fixing keystone rc bug #687311 : permission to upload in SID?

Thomas Goirand <zigo@debian.org> writes:

> Thanks for reviewing the patch, and spotting the leftover set -x in the
> postinst which I missed switching off after my tests.

> On 09/26/2012 02:59 AM, Julien Cristau wrote:
>> Normally the config script doesn't touch configuration files, it reads
>> the current configuration if it exists, updates the values in debconf,
>> then asks the user if necessary.  The postinst then writes the actual
>> config.

> Is this a "must", a "should", or your own packaging habits? Is it
> completely forbidden to do how I did?

config can run during preinst, so you generally should not do anything
that manipulates the file system during config since you can't be
guaranteed that the package is unpacked or that any of its dependencies
are available.  See debconf-devel(7):

    The config script should not need to modify the filesystem at all. It
    just examines the state of the system, and asks questions, and debconf
    stores the answers to be acted on later by the postinst script.
    Conversely, the postinst script should almost never use debconf to ask
    questions, but should instead act on the answers to questions asked by
    the config script.

I'm not sure that I would say "completely forbidden," but it's something
to avoid unless there's some overriding requirement for config to work
that way.

Russ Allbery (rra@debian.org)               <http://www.eyrie.org/~eagle/>

Reply to: