Bug#683311: unblock: htop/1.0.1-2
On Wed, 2012-08-08 at 01:55 +0200, Cyril Brulebois wrote:
> Josh Triplett <josh@joshtriplett.org> (30/07/2012):
> > +--- trunk/Settings.c 2012/02/17 13:45:58 285
> > ++++ trunk/Settings.c 2012/03/05 11:12:58 286
> > +@@ -239,7 +239,9 @@
> > + mkdir(htopDir, 0700);
> > + free(htopDir);
> > + free(configDir);
> > +- if (access(legacyDotfile, R_OK) != 0) {
> > ++ struct stat st;
> > ++ lstat(legacyDotfile, &st);
>
> No error checking here…
>
> RETURN VALUE
> On success, zero is returned. On error, -1 is returned, and errno is
> set appropriately.
>
> What does S_ISLNK() do when an error was reached?
>
> Surely that could be improved?
Ping?
Regards,
Adam
Reply to: