[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Permission to upload melange v 2012.1-3 (RC bug: #684736)



Hi Thomas.

Thomas Goirand <thomas@goirand.fr> (27/08/2012):
> I'd like to upload melange 2012.1-3. Mainly, this adds a missing
> 
> Depends: python-melange (= ${source:Version})
> 
> in the melange binary, which is an RC bug.

Please fix that only.

> But I have also added some aesthetic changes that aren't related, but
> which I consider either very minor change, or documentation related. As
> per the debian/changelog:
> * Added a get-vcs-source target in debian/rules.
> * Added a debian/gbp.conf file.
> * Fixed debian/copyright syntax and Format: URL.

Those don't match the freeze rules. (And frankly, hardcoding the
upstream version in the get-vcs-source target?)

> * Fixed python-melange: capitalization-error-in-description python Python.

I guess we could consider that.

> The first 2 VCS related addition, I would consider it documenting the
> build process using Git, and adding consistency in our Openstack
> packages (nova, keystone, and others, also have these).

Something for the next release cycle.

> Rather be safe than sorry, I'm asking first: is it ok to upload the
> attached changes to SID, then ask for an unblock?

Please fix bugs, please don't add irrelevant changes (aka. please follow
the rules).

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: