Bug#685354: unblock: sendfile/2.1b.20080616-5.1
Hi Adam,
On Thu, Aug 23, 2012 at 07:56:48PM +0100, Adam D. Barratt wrote:
> > The attached patch (against the version in wheezy) should do just that.
>
> Thanks for this.
Thanks for the review,
> -Depends: ${shlibs:Depends}, openbsd-inetd | inet-superserver, perl | perl5
> +Depends: ${shlibs:Depends}, openbsd-inetd | inet-superserver, perl | perl5, update-inetd, libdpkg-perl
The first one (update-inetd) was already there in -5.1 (currently in sid). It
contains /usr/share/perl5/DebianNet.pm, which is needed for
require DebianNet;
which is in the postinst in wheezy (this means the postinst doesn't work if
update-inetd isn't installed).
The second one (libdpkg-perl) is necessary for the version check (the postinst
in wheezy is in perl, and it was my impression that the freeze doesn't allow
changing it to a shell script).
> These aren't explicitly mentioned in the changelog.
Sorry for that.
> +# cleanup edits from versions before 2.1b.20080616-5.2
> +# this can be removed after wheezy
> +if (($ARGV[1] ne "") &&
> + (version_compare($ARGV[1],"2.1b.20080616-5.2") < 0)) {
>
> Is it worth checking this? If there happens to be a new upload that
> makes in to wheezy then running the cleanup in any case doesn't seem
> that bad.
It seems common practice to do this when cleaning up stuff from previous
versions (moving or deleting old config files etc), so it seems logical to do
this here as well.
> + # delete /etc/services with only 1 line created by previous versions of
> + # sendfile
>
> Did that really happen? People actually remove either /etc/services or
> netbase? (I guess maybe on embedded systems, but do they generally have
> Python?)
piuparts doesn't install netbase, so without this piuparts will fail on
upgrade. Whether this is realistic or not is for someone else to decide :)
Cheers,
Ivo
Reply to: