Hi Adam,
On Sat, Aug 18, 2012 at 09:13:42PM +0100, Adam D. Barratt wrote:
> On Tue, 2012-08-07 at 09:10 +0200, Kilian Krause wrote:
> > Please unblock package fex
> >
> > It addresses all currently known issues. It would be great if this could
> > make it into wheezy still to spare us unneccessary work with supporting
> > the 20120215-3 on our own.
>
> + if (open $log,'>',$log) {
>
> Am I missing some Perl trickery here, or should the second $log be
> something else?
This is perfectly ok according to upstream and works as intended.
[...]
> + YOU ARE NOT ALLOWED TO USE THIS SOFTWARE FOR MILITARY PURPOSES OR WITHIN
> + MILITARY ORGANIZATIONS! THIS INCLUDES ALSO MILITARY RESEARCH AND
> + EDUCATION!
>
> That doesn't really seem like something Debian can really meet or
> enforce...
Upstream will try to come forth with an updated license.
> The overall diff is
>
> 187 files changed, 2409 insertions(+), 19174 deletions(-)
>
> Most of the deletions will be the fix removal, but that still leaves
> quite a lot to review, which mostly seems to be made up of small
> changes. I've tried tying some of them up with the upstream changelog,
> but none of that appears to account for e.g. the repeated
> s/time/int(time)/.
>
> Would it be possible to have a filtered diff, ignoring the fix removal,
> documentation changes and the "hidden" easter egg options which upstream
> seem to have added?
I'll see what I can come up with.
--
Best regards,
Kilian
Attachment:
signature.asc
Description: Digital signature