[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684988: marked as done (unblock: libio-async-loop-glib-perl/0.20-2)

Your message dated Wed, 15 Aug 2012 19:56:44 +0100
with message-id <1345057004.16998.2.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#684988: unblock: libio-async-loop-glib-perl/0.20-2
has caused the Debian Bug report #684988,
regarding unblock: libio-async-loop-glib-perl/0.20-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
684988: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684988
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Please unblock package libio-async-loop-glib-perl.

unblock libio-async-loop-glib-perl/0.20-2


0.20-2 fixes RC bug #680806.
The upload adds a patch provided by upstream that removes the
assumption that POLLHUP would work reliably -- which it doesn't.

Upstream bug: https://rt.cpan.org/Public/Bug/Display.html?id=78891

Changelog:

libio-async-loop-glib-perl (0.20-2) unstable; urgency=low

  * Add patch pollhup.patch: remove declaration that IO::Async::Loop::Glib
    can handle on_hangup. POLLHUP is not reliable to detect that the
    reader has closed their end of a pipe. Thanks to Paul Evans (upstream
    author) for the patch. (Closes: #680806)

 -- gregor herrmann <gregoa@debian.org>  Wed, 15 Aug 2012 15:12:49 +0200


Complete debdiff attached.


Thank in advance,
gregor

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQK6V1AAoJELs6aAGGSaoGU8MQAJ+3En+cYOor7VVPCkle6rq1
3Sbq5ftzf0nNTyh2HBrex3FeFkjf0LZcsnulkvz2cxa/WByQHGVP3GMe9LmOi9GG
bRspMxa6y4TNJaeuDtOB34Z97IzZgl8SnZGcjFqY1JR2OmozxG8ke65ptI8g3Nal
Z6Co4WrlwlC6c2fO9FeO8CG8Fwfc3pqZFowwD3EXhp91OxbbFhUtiFbmJfL2kd5E
2Q28MQugIVhUjwYS2YEFDG4nNmHiszdDmPNE+eFYBQDW1mmuoS7gvuHyFRNqCjPw
lnDUt/vbanR9Nu87qoa4Q95QgovMJECxqkbN771kSbljIF4/PdUrM5EzlusG/jS6
YRNHEsE6Oo9TunEuMTR2Opt0dHdxqPnS9h5zO5VBfBEP/dzV0KvMFxf3Ml32yAJU
Ly8nzmL49CXWEI0KUVtc9ynsS2Uz2/jakXMc8mgfsrEigxrFm1aptgWgksy75mr1
Kr7OZUVP2EHuLQafn6uQWxuoZGQ7TXz0F2cezgeyf3Jg5BVhIgi1TFVZ/GIRcb2j
gfRAWaxOkxJIUV4396LbsZPFXmaabJYQmmGO970CBu36kFaUGRUGppb5CwpDRMcL
qH8R9dYp99s8jO4X0vZ/kp8+vhyW8V7KczHU26aOTJDSlQQv244bfTRDFBaRIkA2
NpuWHeBCbJSkBo9x+56Y
=s2eq
-----END PGP SIGNATURE-----

diff -Nru libio-async-loop-glib-perl-0.20/debian/changelog libio-async-loop-glib-perl-0.20/debian/changelog
--- libio-async-loop-glib-perl-0.20/debian/changelog	2011-09-18 18:23:28.000000000 +0200
+++ libio-async-loop-glib-perl-0.20/debian/changelog	2012-08-15 15:16:32.000000000 +0200
@@ -1,3 +1,12 @@
+libio-async-loop-glib-perl (0.20-2) unstable; urgency=low
+
+  * Add patch pollhup.patch: remove declaration that IO::Async::Loop::Glib
+    can handle on_hangup. POLLHUP is not reliable to detect that the
+    reader has closed their end of a pipe. Thanks to Paul Evans (upstream
+    author) for the patch. (Closes: #680806)
+
+ -- gregor herrmann <gregoa@debian.org>  Wed, 15 Aug 2012 15:12:49 +0200
+
 libio-async-loop-glib-perl (0.20-1) unstable; urgency=low
 
   * Team upload.
diff -Nru libio-async-loop-glib-perl-0.20/debian/patches/pollhup.patch libio-async-loop-glib-perl-0.20/debian/patches/pollhup.patch
--- libio-async-loop-glib-perl-0.20/debian/patches/pollhup.patch	1970-01-01 01:00:00.000000000 +0100
+++ libio-async-loop-glib-perl-0.20/debian/patches/pollhup.patch	2012-08-15 15:16:32.000000000 +0200
@@ -0,0 +1,22 @@
+Description: remove IaLoop::Glib's declaration that it can handle on_hangup
+ "[The bug] comes from an expectation on my part hat POLLHUP was actually
+ reliable across operating systems, to detect that the reader has closed
+ their end of a pipe. Turns out this really isn't the case at all."
+Origin: upstream, RT#78891
+Bug: http://rt.cpan.org/Public/Bug/Display.html?id=78891
+Bug-Debian: http://bugs.debian.org/680806
+Author: Paul Evans <leonerd@leonerd.org.uk>
+Reviewed-by: gregor herrmann <gregoa@debian.org>
+Last-Update: 2012-08-15
+
+--- a/lib/IO/Async/Loop/Glib.pm
++++ b/lib/IO/Async/Loop/Glib.pm
+@@ -13,7 +13,7 @@
+ 
+ # Only Linux is known always to be able to report EOF conditions on
+ # filehandles using POLLHUP
+-use constant _CAN_ON_HANGUP => ( $^O eq "linux" );
++#use constant _CAN_ON_HANGUP => ( $^O eq "linux" );
+ 
+ use base qw( IO::Async::Loop );
+ IO::Async::Loop->VERSION( '0.33' );
diff -Nru libio-async-loop-glib-perl-0.20/debian/patches/series libio-async-loop-glib-perl-0.20/debian/patches/series
--- libio-async-loop-glib-perl-0.20/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ libio-async-loop-glib-perl-0.20/debian/patches/series	2012-08-15 15:16:32.000000000 +0200
@@ -0,0 +1 @@
+pollhup.patch

--- End Message ---
--- Begin Message --- 
On Wed, 2012-08-15 at 15:34 +0200, gregor herrmann wrote:
> Please unblock package libio-async-loop-glib-perl.
[...]
> The upload adds a patch provided by upstream that removes the
> assumption that POLLHUP would work reliably -- which it doesn't.

Unblocked; thanks.

Regards,

Adam

--- End Message ---
Reply to: