Bug#684735: unblock: ganglia (security)
On Mon, 2012-08-13 at 14:11 +0000, Daniel Pocock wrote:
> > Please could we have a full source debdiff for a proposed upload as part
> > of this bug log? It makes it far clearer what was requested to be acked
> > and what was (or wasn't) acked.
>
> debdiff attached
Thanks. A few queries:
+Uploaders: Daniel Pocock <daniel@pocock.com.au>
[...]
+DM-Upload-Allowed: yes
Those aren't mentioned at all in the changelog, as far as I can tell.
Were they acked by the maintainer?
+Vcs-Git: git://git.debian.org/collab-maint/ganglia.git
+Vcs-Browser: http://git.debian.org/?p=collab-maint/ganglia.git;a=summary
Those should also be mentioned in the changelog.
diff -Nru ganglia-3.3.5/debian/patches/debian-changes-3.3.8-1 ganglia-3.3.8/debian/patches/debian-changes-3.3.8-1
[...]
+--- ganglia-3.3.8.orig/gmond/modules/python/README
++++ ganglia-3.3.8/gmond/modules/python/README
+@@ -101,11 +101,11 @@ follows:
+ module {
+ name = "python_module"
+ path = "modpython.so"
+- params = "/usr/local/lib64/ganglia/python_modules"
++ params = "/usr/lib/ganglia/python_modules"
+ }
+ }
+
+- include ('/usr/local/etc/conf.d/*.pyconf')
++ include ('/etc/ganglia/conf.d/*.pyconf')
+
Were these intended to be included? Is there a reason they're not a) a
separate patch and b) in the changelog?
diff -Nru ganglia-3.3.5/debian/rules ganglia-3.3.8/debian/rules
---
[...]
# Add here commands to configure the package.
- ./bootstrap
- chmod +x configure libmetrics/configure
+ #./bootstrap
+ #chmod +x configure libmetrics/configure
Why does "bootstrap" go away? I spotted that the script is also
removed.
+int
+get_apr_os_socket(apr_socket_t *socket)
+{
+ return socket->socketdes;
+}
Was there a problem with the direct uses of "sock->socketdes" which were
previously used?
Out of interest, do you know wish parts of the diff address this
changelog entry?
+ * Fix issue where Ganglia fails to start with NetworkManager
Regards,
Adam
Reply to: