Quoting Nicholas Bamber (nicholas@periapt.co.uk): > Ansgar, > I have not finished testing your patch but I have a few questions. > > Firstly it raises a new lintian error requiring a Pre-Depends on dpkg > (=> 1.15.6~). I know that this is more of an issue for Ubuntu and that > Ubuntu won't in this case be syncing from wheezy, so I guess we can live > with the warning. But to be careful I thought I had better run it past > you. I certainly would want to follow lintian's advice post-wheezy. In samba, I added this predependency to all binary packages. Just don't forget mentioning it in the changelog. I think it is OK to do that. This predependency is needed to guarantee that dpkg can unpack the .deb files. It happens to be satisfied anyway in squeeze and wheezy but it can help derivatives and people who use backports. > > Also you say " please keep in mind to not include additional changes." > however I also have #683733 to fix which I think I should be in the > same release. That, I can't have any advice about but if that's a release critical issue, it probably qualify. If it isn't (for instance an important bug which you'd like to get fixed but needs the release team approval), I'd recommend fixing it in *another* upload.
Attachment:
signature.asc
Description: Digital signature