[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#684045: pre-approval simplesamlphp/1.9.1-1



Thijs Kinkhorst <thijs@debian.org> (07/08/2012):
> On Tue, August 7, 2012 01:44, Cyril Brulebois wrote:
> > while I have only glanced at it, that doesn't look bad at all,
> > please go ahead and ping us once it's accepted.
> 
> It has now been accepted.

Thanks. Now that I have a little more time, finally looking at it for
real.

OK for doc changes, and $Id$ noise (…).

I think I can see what the key dance part of the patch does, too.

That is totally obscure to me though:
-         if (!$newDoc->loadXML($xml)) {
+         if (!@$newDoc->loadXML($xml)) {

What does that do? Fix a bug, silence a language warning, or anything
else?

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: