[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#683280: unblock: moin/1.9.4-5



On Mon, 2012-07-30 at 13:53 +0100, Steve McIntyre wrote:
> Please unblock package moin
> 
> Small changes to add extra features to help with anti-spam. Once it's
> in testing I'll do a backport again so that we can get the new code
> onto wiki.debian.org. Debdiff attached.

Possibly a little picky (or misunderstanding), but:

++            create_error = subprocess.check_output([request.cfg.external_creation_check,
++                           theuser.name,
++                           theuser.email,
++                           theuser.account_creation_host])
++            if create_error:
++                request.theme.add_msg(_("Unable to send verification mail, %s. Account creation aborted." % create_error), "error")

Isn't the error in this case that the account creation failed, rather
than the sending of the mail?

Regards,

Adam


Reply to: