Bug#682392: marked as done (unblock: tap-plugins/0.7.2-1)

To: Julien Cristau <jcristau@debian.org>
Subject: Bug#682392: marked as done (unblock: tap-plugins/0.7.2-1)
From: owner@bugs.debian.org (Debian Bug Tracking System)
Date: Sat, 28 Jul 2012 11:57:04 +0000
Message-id: <handler.682392.D682392.13434764188443.ackdone@bugs.debian.org>
References: <20120728115334.GB17223@radis.cristau.org> <20120722113423.9849.99066.reportbug@Aspire-1410>

Your message dated Sat, 28 Jul 2012 13:53:34 +0200
with message-id <20120728115334.GB17223@radis.cristau.org>
and subject line Re: Bug#682392: unblock: tap-plugins/0.7.2-1
has caused the Debian Bug report #682392,
regarding unblock: tap-plugins/0.7.2-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
682392: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=682392
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

--- Begin Message ---

To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: unblock: tap-plugins/0.7.2-1
From: Alessio Treglia <alessio@debian.org>
Date: Sun, 22 Jul 2012 13:34:23 +0200
Message-id: <20120722113423.9849.99066.reportbug@Aspire-1410>

Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package tap-plugins 0.7.2-1.

I've uploaded the most recent upstream release to unstable in order to fix
an annoying issue encountered when using one of the plugins provided by the
suite:

  - Fix sharp peaks / level jumps in the output when using the Scaling
    Limiter plugin.

The debdiff between versions in testing and unstable is attached.
Thanks for considering.

unblock tap-plugins/0.7.2-1

-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 'precise'), (100, 'precise-backports')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-26-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru tap-plugins-0.7.1/CREDITS tap-plugins-0.7.2/CREDITS
--- tap-plugins-0.7.1/CREDITS	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/CREDITS	2012-07-08 16:16:01.000000000 +0200
@@ -58,6 +58,9 @@
 caused problems on 64-bit machines, found uninitialised variables via
 Valgrind, and also pinned down long lurking denormal issues. Thanks!
 
+Taku Yamamoto <taku@tackymt.homeip.net> investigated a buffer boundary
+related bug in Scaling Limiter and provided a patch solving the problem.
+
 
 And, of course, special thanks to the Ardour [http://ardour.org] and
 JACK [http://jackit.sf.net] development teams for their tireless
diff -Nru tap-plugins-0.7.1/debian/changelog tap-plugins-0.7.2/debian/changelog
--- tap-plugins-0.7.1/debian/changelog	2011-07-01 12:19:13.000000000 +0200
+++ tap-plugins-0.7.2/debian/changelog	2012-07-18 16:58:26.000000000 +0200
@@ -1,3 +1,14 @@
+tap-plugins (0.7.2-1) unstable; urgency=low
+
+  * Team upload.
+  * New bugfix release:
+    - Fix sharp peaks / level jumps in the output when using the Scaling
+      Limiter plugin.
+  * Update debian/copyright.
+  * Bump Standards.
+
+ -- Alessio Treglia <alessio@debian.org>  Wed, 18 Jul 2012 16:56:59 +0200
+
 tap-plugins (0.7.1-2) unstable; urgency=low
 
   * Team upload.
diff -Nru tap-plugins-0.7.1/debian/control tap-plugins-0.7.2/debian/control
--- tap-plugins-0.7.1/debian/control	2011-07-01 12:15:04.000000000 +0200
+++ tap-plugins-0.7.2/debian/control	2012-07-18 16:56:40.000000000 +0200
@@ -5,7 +5,7 @@
 Uploaders: Jaromír Mikeš <mira.mikes@seznam.cz>
 Build-Depends: debhelper (>= 7.0.50~),
  sharutils
-Standards-Version: 3.9.2
+Standards-Version: 3.9.3
 DM-Upload-Allowed: yes
 Vcs-Git: git://git.debian.org/git/pkg-multimedia/tap-plugins.git
 Vcs-Browser: http://git.debian.org/?p=pkg-multimedia/tap-plugins.git
diff -Nru tap-plugins-0.7.1/debian/copyright tap-plugins-0.7.2/debian/copyright
--- tap-plugins-0.7.1/debian/copyright	2011-07-01 12:13:54.000000000 +0200
+++ tap-plugins-0.7.2/debian/copyright	2012-07-18 16:56:05.000000000 +0200
@@ -1,4 +1,4 @@
-Format: http://svn.debian.org/wsvn/dep/web/deps/dep5.mdwn?op=file&rev=174
+Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: TAP-plugins
 Upstream-Contact: Tom Szilagyi <tszilagyi@users.sourceforge.net>
 Source: http://sourceforge.net/projects/tap-plugins/files/
@@ -14,7 +14,7 @@
 
 Files: debian/*
 Copyright:
- 2010 Alessio Treglia <quadrispro@ubuntu.com>
+ 2010-2012 Alessio Treglia <quadrispro@ubuntu.com>
  2010 Jaromír Mikeš <mira.mikes@seznam.cz>
  2004 Anand Kumria <wildfire@progsoc.org>
 License: GPL-2+
@@ -29,9 +29,9 @@
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.
-Comment: You should have received a copy of the GNU General Public License
- along with this package; if not, write to the Free Software
- Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
+Comment:
+ You should have received a copy of the GNU General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
  .
  On Debian systems, the complete text of the GNU General
  Public License can be found in `/usr/share/common-licenses/GPL-2'.
@@ -46,9 +46,9 @@
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  Lesser General Public License for more details.
-Comment: You should have received a copy of the GNU Lesser General Public
- License along with this library; if not, write to the Free Software
- Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+Comment:
+ You should have received a copy of the GNU Lesser General Public License
+ along with this program.  If not, see <http://www.gnu.org/licenses/>.
  .
- On Debian systems, the complete text of the GNU General
+ On Debian systems, the complete text of the GNU Lesser General
  Public License can be found in `/usr/share/common-licenses/LGPL-2.1'.
diff -Nru tap-plugins-0.7.1/debian/gbp.conf tap-plugins-0.7.2/debian/gbp.conf
--- tap-plugins-0.7.1/debian/gbp.conf	2011-07-01 12:12:46.000000000 +0200
+++ tap-plugins-0.7.2/debian/gbp.conf	2012-07-18 16:52:21.000000000 +0200
@@ -1,3 +1,2 @@
 [DEFAULT]
 pristine-tar = True
-sign-tags = True
diff -Nru tap-plugins-0.7.1/Makefile tap-plugins-0.7.2/Makefile
--- tap-plugins-0.7.1/Makefile	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/Makefile	2009-08-17 13:16:19.000000000 +0200
@@ -14,7 +14,7 @@
 #   along with this program; if not, write to the Free Software
 #   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 #
-#   $Id: Makefile,v 1.17 2006/11/26 19:42:44 tszilagyi Exp $
+#   $Id: Makefile,v 1.18 2009/08/17 11:16:19 tszilagyi Exp $
 
 
 #####################################################################
diff -Nru tap-plugins-0.7.1/tap_eqbw.c tap-plugins-0.7.2/tap_eqbw.c
--- tap-plugins-0.7.1/tap_eqbw.c	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/tap_eqbw.c	2009-08-17 13:16:19.000000000 +0200
@@ -15,7 +15,7 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
     
-    $Id: tap_eqbw.c,v 1.5 2006/08/09 12:03:24 tszilagyi Exp $
+    $Id: tap_eqbw.c,v 1.6 2009/08/17 11:16:19 tszilagyi Exp $
 */
 
 
diff -Nru tap-plugins-0.7.1/tap_eq.c tap-plugins-0.7.2/tap_eq.c
--- tap-plugins-0.7.1/tap_eq.c	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/tap_eq.c	2009-08-17 13:16:19.000000000 +0200
@@ -15,7 +15,7 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
     
-    $Id: tap_eq.c,v 1.7 2006/08/09 12:03:24 tszilagyi Exp $
+    $Id: tap_eq.c,v 1.8 2009/08/17 11:16:19 tszilagyi Exp $
 */
 
 
diff -Nru tap-plugins-0.7.1/tap_limiter.c tap-plugins-0.7.2/tap_limiter.c
--- tap-plugins-0.7.1/tap_limiter.c	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/tap_limiter.c	2012-07-08 16:19:35.000000000 +0200
@@ -15,7 +15,7 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id: tap_limiter.c,v 1.5 2004/02/21 17:33:36 tszilagyi Exp $
+    $Id: tap_limiter.c,v 1.6 2012/07/08 14:19:35 tszilagyi Exp $
 */
 
 
@@ -176,18 +176,38 @@
 			if (read_buffer(ptr->ringbuffer, ptr->buflen,
 					ptr->pos, ptr->ready_num) >= 0.0f) {
 				index_offs = 0;
-				while ((read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
-						    ptr->ready_num + index_offs) >= 0.0f) &&
-				       (ptr->ready_num + index_offs < run_length)) {
+				do {
 					index_offs++;
-				}
+					if (ptr->ready_num + index_offs == run_length) {
+						/*
+						 * No more zero-crossing point in this chunk.
+						 * Fetch more samples unless we are at the last one.
+						 */
+						if (ptr->ready_num != 0) {
+							run_length = ptr->ready_num;
+							goto push;
+						}
+						break;
+					}
+				} while (read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
+						     ptr->ready_num + index_offs) >= 0.0f);
 			} else {
 				index_offs = 0;
-				while ((read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
-						    ptr->ready_num + index_offs) <= 0.0f) &&
-				       (ptr->ready_num + index_offs < run_length)) {
+				do {
 					index_offs++;
-				}
+					if (ptr->ready_num + index_offs == run_length) {
+						/*
+						 * No more zero-crossing point in this chunk.
+						 * Fetch more samples unless we are at the last one.
+						 */
+						if (ptr->ready_num != 0) {
+							run_length = ptr->ready_num;
+							goto push;
+						}
+						break;
+					}
+				} while (read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
+						     ptr->ready_num + index_offs) < 0.0f);
 			}
 			
 			/* search for max value in scanned halfcycle */
@@ -208,6 +228,7 @@
 			ptr->ready_num += index_offs;			
 		}
 		
+	push:
 		/* push run_length values out of ringbuffer, feed with input */
 		for (sample_index = 0; sample_index < run_length; sample_index++) {
 			*(output++) = out_vol * 
@@ -262,18 +283,38 @@
 			if (read_buffer(ptr->ringbuffer, ptr->buflen,
 					ptr->pos, ptr->ready_num) >= 0.0f) {
 				index_offs = 0;
-				while ((read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
-						    ptr->ready_num + index_offs) >= 0.0f) &&
-				       (ptr->ready_num + index_offs < run_length)) {
+				do {
 					index_offs++;
-				}
+					if (ptr->ready_num + index_offs == run_length) {
+						/*
+						 * No more zero-crossing point in this chunk.
+						 * Fetch more samples unless we are at the last one.
+						 */
+						if (ptr->ready_num != 0) {
+							run_length = ptr->ready_num;
+							goto push;
+						}
+						break;
+					}
+				} while (read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
+						     ptr->ready_num + index_offs) >= 0.0f);
 			} else {
 				index_offs = 0;
-				while ((read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
-						    ptr->ready_num + index_offs) <= 0.0f) &&
-				       (ptr->ready_num + index_offs < run_length)) {
+				do {
 					index_offs++;
-				}
+					if (ptr->ready_num + index_offs == run_length) {
+						/*
+						 * No more zero-crossing point in this chunk.
+						 * Fetch more samples unless we are at the last one.
+						 */
+						if (ptr->ready_num != 0) {
+							run_length = ptr->ready_num;
+							goto push;
+						}
+						break;
+					}
+				} while (read_buffer(ptr->ringbuffer, ptr->buflen, ptr->pos,
+						     ptr->ready_num + index_offs) < 0.0f);
 			}
 			
 			/* search for max value in scanned halfcycle */
@@ -294,6 +335,7 @@
 			ptr->ready_num += index_offs;			
 		}
 		
+	push:
 		/* push run_length values out of ringbuffer, feed with input */
 		for (sample_index = 0; sample_index < run_length; sample_index++) {
 			*(output++) += ptr->run_adding_gain * out_vol * 
diff -Nru tap-plugins-0.7.1/tap_reverb.h tap-plugins-0.7.2/tap_reverb.h
--- tap-plugins-0.7.1/tap_reverb.h	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/tap_reverb.h	2009-08-17 13:16:19.000000000 +0200
@@ -15,7 +15,7 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id: tap_reverb.h,v 1.10 2004/06/14 16:43:55 tszilagyi Exp $
+    $Id: tap_reverb.h,v 1.11 2009/08/17 11:16:19 tszilagyi Exp $
 */
 #ifndef _ISOC99_SOURCE
 #define _ISOC99_SOURCE
diff -Nru tap-plugins-0.7.1/tap_utils.h tap-plugins-0.7.2/tap_utils.h
--- tap-plugins-0.7.1/tap_utils.h	2009-08-17 13:10:57.000000000 +0200
+++ tap-plugins-0.7.2/tap_utils.h	2009-08-17 13:16:19.000000000 +0200
@@ -15,7 +15,7 @@
     along with this program; if not, write to the Free Software
     Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-    $Id: tap_utils.h,v 1.5 2004/02/21 17:33:36 tszilagyi Exp $
+    $Id: tap_utils.h,v 1.6 2009/08/17 11:16:19 tszilagyi Exp $
 */
 #ifndef _ISOC99_SOURCE
 #define _ISOC99_SOURCE

--- End Message ---

--- Begin Message ---

To: Alessio Treglia <alessio@debian.org>, 682392-done@bugs.debian.org

Subject: Re: Bug#682392: unblock: tap-plugins/0.7.2-1

From: Julien Cristau <jcristau@debian.org>

Date: Sat, 28 Jul 2012 13:53:34 +0200

Message-id: <20120728115334.GB17223@radis.cristau.org>

In-reply-to: <20120722113423.9849.99066.reportbug@Aspire-1410>

References: <20120722113423.9849.99066.reportbug@Aspire-1410>
On Sun, Jul 22, 2012 at 13:34:23 +0200, Alessio Treglia wrote:

> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package tap-plugins 0.7.2-1.
> 
Unblocked.

Cheers,
Julien
Attachment: signature.asc
Description: Digital signature

--- End Message ---

Reply to:

References:
- Bug#682392: unblock: tap-plugins/0.7.2-1
  - From: Alessio Treglia <alessio@debian.org>

Prev by Date: please unblock open-vm-tools (rc bugfix)
Next by Date: Bug#682402: marked as done (unblock: libxml2/2.8.0+dfsg1-5)
Previous by thread: Bug#682392: unblock: tap-plugins/0.7.2-1
Next by thread: Bug#682393: unblock: bindfs/1.10.3-2
Index(es):
- Date
- Thread