On Mon, Jul 23, 2012 at 07:18:29PM +0200, Guillem Jover wrote:
> On Mon, 2012-07-23 at 17:51:56 +0100, Neil McGovern wrote:
> > Nope, 1.16.5. I'd like to see that to get a view as to why 1.16.5 was
> > broken. Once we've managed to have a look at that, it may give a clue as
> > to if it's worth reviewing the giant-diff-from-doom.
>
> Thanks, attached the filtered diff (with additional junk left by
> filterdiff, but left the changelog) from git:
>
Right, the delta diff was small enough that I actually put in the time
to look at the full diff. This took a number of hours, but anyway:
Some questions:
dpkg-1.16.8/dpkg-deb/main.c
-" -h|--help Show this help message.\n"
-" --version Show the version.\n"
+" -?, --help Show this help message.\n"
+" --version Show the version.\n"
Why are you removing -h?
dpkg-1.16.8/lib/dpkg/ar.c
+ if (strlen(name) > 15)
+ ohshit(_("ar member name '%s' length too long"), name);
+ if (size > 9999999999L)
+ ohshit(_("ar member size %jd too large"), size);
+
Why 9999999999?
dpkg-1.16.8/scripts/Dpkg/Deps.pm
- (any) # architecture name
+ ([a-zA-Z0-9][a-zA-Z0-9-]*) # architecture name
Why the additional restriction?
*.gmo - are you sure you're meant to be shipping these in the tarball?
Thanks,
Neil
--
Attachment:
signature.asc
Description: Digital signature