Re: Bug#682046: unblock: django-celery/2.5.5-2
On Fri, Jul 20, 2012 at 12:01:07AM +0200, Philipp Kern wrote:
> On Thu, Jul 19, 2012 at 07:30:49AM +0200, Michael Fladischer wrote:
> > It fixes a FTBFS which occured because it tried to connect to github
> > while building the documentation. There's now a patch included to
> > disable this behaviour in the upstream documentation during build,
> > controllable through an environment variable.
> >
> > debdiff is attached.
> >
> > unblock django-celery/2.5.5-2
>
> And the buildsystem uses hasattr or something similar to access the
> issuetracker* variables? Because they're now left undefined…
Allow me to reply, as I wrote the patch.
They are not undefined :)
Issuetracker sets them to None during setup [1] and the config we edit
just sets them to something useful instead. And the whole code is only
executed when config.issuetracker is not None [2].
Hope this clarifies it.
Regards
Evgeni
[1] https://github.com/lunaryorn/sphinxcontrib-issuetracker/blob/master/sphinxcontrib/issuetracker/__init__.py#L312
[2] https://github.com/lunaryorn/sphinxcontrib-issuetracker/blob/master/sphinxcontrib/issuetracker/__init__.py#L280
--
Bruce Schneier can read and understand Perl programs.
Reply to: