Bug#681644: unblock: ldm-themes/12.07.1

[Vagrant Cascadian <vagrant@freegeek.org>]

On Sun, Jul 15, 2012 at 02:25:34PM +0100, Adam D. Barratt wrote:
> On Sat, 2012-07-14 at 17:27 -0700, Vagrant Cascadian wrote:
> > ldm-themes (12.07.1) unstable; urgency=low
> > 
> >   [ Jonathan Carter ]
> >   * Remove all alternatives (Closes: #679208).
> 
> The only alternatives-related change I can see in the diff is this in
> the prerm:
> 
>      remove|deconfigure|failed-upgrade)
>          update-alternatives --remove ldm-theme \
> -            /usr/share/ldm/themes/spacefun
> +            /usr/share/ldm/themes/joy
> 
> which looks like part of the general theme switch changes.  Is that
> correct?  

Ah, that part of the changelog was written while we still were trying to ship 
both spacefun and joy, but it turned out to be an even uglier diff and seemed
better to just remove spacefun.

> Was the addition of a --remove call in postrm (as suggested in
> #679208) considered?

I think what really triggered that bug was the 12.06.1 version shipped both 
spacefun and joy, but only removed spacefun.

I did consider the additional postrm call suggested, but it generated lintian 
warnings; it seems like there is not real consensus on how to handle 
"update-alternatives --remove" so I followed the path that seemed to actually 
fix the bug that didn't produce lintian warnings and complies with policy as it 
currently stands.

Thanks for the ever-villigent review!

live well,
  vagrant