[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#681463: unblock: gyoto/0.0.3-5



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package gyoto.

I attach a debdiff and explain the changes below.

1- Security Hardening Buld Flags Release Goal
   http://bugs.debian.org/680242

Fix: pass build flags explicitly to make. I had to reshuffle some
symbolic targets in debian/rules to make it work reliably. Could be made
cleaner, but I tried to keep changes to a minimum.

2- test suite failed on kfreebsd-any
   http://bugs.debian.org/679923

After checking, it appears that the "gyoto" executable from the gyoto
binary package fails to run on kfreebsd. However, the same functionality
is exposed to the Yorick interpreter by the yorick-gyoto package and
this binary package runs fine.

Fix:
 - disable building the gyoto binary package on kfreebsd;
 - don't let gyoto-dbg (or anything else) depend on it on kfreebsd;
 - disable the test suite on kfreebsd, which requires the gyoto
   executable to run.

3- test suite failed on some mips buildds
   http://bugs.debian.org/681452

After checking, it appears that this failure does not affect all the
machines. It may just be that the test suite is too expensive to run on
some smaller/slower buildds.

Fix: disable test suite on mips. I then tested manually the autobuilt
binaries, which run fine (although slowwwly) in my qemu installation.

4- yorick is waiting for yorick-gyoto
The yorick-full meta-package (src:yorick), already unblocked, is waiting
for yorick-gyoto to build on kfreebsd-* before it can migrate.
   http://release.debian.org/migration/testing.pl?package=yorick
Fixing the above-mentioned FTBFSes takes us halfway through to letting
yorick migrate. The other half is unblocking yp-svipc, already requested
here:
   http://bugs.debian.org/681314

Kind regards, Thibaut.

unblock gyoto/0.0.3-5
diff -Nru gyoto-0.0.3/debian/changelog gyoto-0.0.3/debian/changelog
--- gyoto-0.0.3/debian/changelog	2012-06-25 20:03:10.000000000 +0200
+++ gyoto-0.0.3/debian/changelog	2012-07-13 11:36:16.000000000 +0200
@@ -1,5 +1,44 @@
+gyoto (0.0.3-5) unstable; urgency=low
+
+  * skip test suite on mips as lucatelli fails on it (but it runs fine on
+    other boxes). (Closes: 681452)
+
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Fri, 13 Jul 2012 11:36:16 +0200
+
+gyoto (0.0.3-4) unstable; urgency=low
+
+  * gyoto-dbg must not depend on gyoto on kfreebsd-*, else it is
+    uninstallable on these archs.
+
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Wed, 11 Jul 2012 14:30:02 +0200
+
+gyoto (0.0.3-3) unstable; urgency=low
+
+  * debian/control Architectures fields should not be folded: previous
+    upload led to missing binary packages for some archs.
+
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Wed, 11 Jul 2012 13:02:34 +0200
+
+gyoto (0.0.3-2) unstable; urgency=low
+
+  * Bug fix: "FTBFS on kfreebsd-i386 and kfreebsd-amd64 (test suite)",
+    (Closes: #679923). The previous "fix" did not work at all. The library
+    and the Yorick interface work fine, but not the stand-alone application.
+    Disable the "gyoto" binary package and the test suite on kfreebsd-*.
+
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Wed, 11 Jul 2012 11:20:09 +0200
+
+gyoto (0.0.3-1+exp1) experimental; urgency=low
+
+  * Bug fix: "FTBFS on kfreebsd-i386 and kfreebsd-amd64 (test suite)"
+    (Closes: #679923).
+  * Tentative bug fix: "don't rely on yorick to pass the fortified build
+    flags" using patch fix_679923_kfreebsd_FTBFS (Closes: #680242).
+
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Tue, 10 Jul 2012 10:50:50 +0200
+
 gyoto (0.0.3-1) unstable; urgency=low
 
   * Initial release (Closes: #640809)
 
- -- Thibaut Paumard <paumard@users.sourceforge.net>  Mon, 25 Jun 2012 20:03:10 +0200
+ -- Thibaut Paumard <paumard@users.sourceforge.net>  Fri, 22 Jun 2012 14:22:40 +0200
diff -Nru gyoto-0.0.3/debian/control gyoto-0.0.3/debian/control
--- gyoto-0.0.3/debian/control	2012-06-22 14:21:54.000000000 +0200
+++ gyoto-0.0.3/debian/control	2012-07-11 14:29:51.000000000 +0200
@@ -12,7 +12,7 @@
 Homepage: http://gyoto.obspm.fr
 
 Package: gyoto
-Architecture: any
+Architecture: linux-any hurd-any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: General relativistic ray-tracing
  Gyoto is a framework for computing geodesics in curved
@@ -41,7 +41,7 @@
 Architecture: any
 Section: debug
 Depends: libgyoto0 (= ${binary:Version}),
-	 gyoto (= ${binary:Version}),
+	 gyoto (= ${binary:Version}) [!kfreebsd-any],
 	 yorick-gyoto (= ${binary:Version}),
 	 ${misc:Depends}
 Description: debugging symbols for gyoto, libgyoto0 and yorick-gyoto
diff -Nru gyoto-0.0.3/debian/rules gyoto-0.0.3/debian/rules
--- gyoto-0.0.3/debian/rules	2012-06-25 19:49:54.000000000 +0200
+++ gyoto-0.0.3/debian/rules	2012-07-13 10:56:48.000000000 +0200
@@ -5,6 +5,8 @@
 # This has to be exported to make some magic below work.
 export DH_OPTIONS
 
+DEB_HOST_ARCH := $(shell dpkg-architecture -qDEB_HOST_ARCH)
+
 # Hardened flags
 DPKG_EXPORT_BUILDFLAGS = 1
 -include /usr/share/dpkg/buildflags.mk
@@ -33,17 +35,29 @@
 	dh_compress -i
 	dh_fixperms -i
 
-build-arch build-stamp:
+build: build-arch build-indep
+build-arch: build-stamp
+build-indep: doc-stamp
+
+override_dh_auto_build:
+
+build-stamp:
 	dh_testdir -a
-	dh_auto_build -a
+	make COPT_DEFAULT="" \
+	     Y_CFLAGS="$(CFLAGS) $(CPPFLAGS)" \
+	     Y_LDFLAGS="$(LDFLAGS)"
 ifeq (,$(filter nocheck, $(DEB_BUILD_OPTIONS)))
+ifeq (,$(filter $(DEB_HOST_ARCH), kfreebsd-i386 kfreebsd-amd64 mips))
+# skip the test suite on kfreebsd-any as gyoto package not beeing built
+# skip on mips as lucatelli2 fails on it (but the binary works on other boxes)
 	make check
 endif
+endif
 	touch build-stamp
 
-build-indep doc-stamp:
+doc-stamp:
 	dh_testdir -i
-	dh_auto_build -i -- doc
+	make doc
 	touch doc-stamp
 
 binary: binary-indep binary-arch

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: