[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#681395: unblock smarty-gettext

Hi Adam,

thanks for the quick reply.

On Do 12 Jul 2012 22:50:23 CEST "Adam D. Barratt" wrote:

On 12.07.2012 21:09, Mike Gabriel wrote:
Package smarty-gettext 1.0b1-6 got broken by changing from smarty 3.0
to smarty 3.1. A patch against upstream 1.0b1 has been uploaded to
SID  with smarty-gettext 1.0b1-7.

What's this change about?

+  * debian/install, debian/links:
+    + Install as /usr/bin/tsmarty2c (without extension) and drop the symlink
+      of the same name that used to refer to /usr/bin/tsmarty2c.php.

1.0b1-6 had three locations within /debian dir that played around with the file tsmarty2c.php (name that upstream gave the file): debian/install, debian/links and debian/rules. The job done in debian/links and the command in debian/rules obviously interfered with each other.

Furthermore, in 1.0b1-6 I had these lintian warnings:

W: smarty-gettext: binary-without-manpage usr/bin/tsmarty2c
W: smarty-gettext: binary-without-manpage usr/bin/tsmarty2c.php

Obviously, one being a duplicate of the other... So for 1.0b1-7 I had two goals: get rid of the duplication and provide a man page. As files in /usr/bin are not supposed to have file extension (§ 10.4), I decided for copying tsmarty2c.php first (dh_install) and then rename it in situ (debian/rules:override_dh_install).

There doesn't appear to be any documentation or rationale beyond the above;
furthermore, the change appears to be broken:

--- smarty-gettext-1.0b1/debian/install 2012-05-10 18:59:25.000000000 +0000
+++ smarty-gettext-1.0b1/debian/install 2012-07-08 13:07:48.000000000 +0000
@@ -1,2 +1,2 @@
 block.t.php usr/share/php/smarty3/plugins/
-tsmarty2c.php usr/bin/
+tsmarty2c.php usr/bin/
 No newline at end of file

This file only has lost an EOL (sorry for causing confusion). Again the mech is copy tsmarty2c.php to usr/bin and the rename it there to tsmarty2c (via debian/rules).



mike gabriel, rothenstein 5, 24214 neudorf-bornstein
fon: +49 (1520) 1976 148

GnuPG Key ID 0xB588399B
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de


Attachment: pgpWT8I30ppVd.pgp
Description: Digitale PGP-Unterschrift

Reply to: