[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#680895: unblock: libtext-tabulardisplay-perl/1.33-1 (asking for pre-approval, package not uploaded yet)



Hello Cyril

On Mon, Jul 09, 2012 at 12:56:41AM +0200, Cyril Brulebois wrote:
> Hello Salvatore,
> 
> Salvatore Bonaccorso <carnil@debian.org> (09/07/2012):
> > It was reported a FTBFS with libtext-recordparser-perl [1].
> > 
> >  [1]: http://bugs.debian.org/680831
> > 
> > But this actually is a bug in libtext-tabulardisplay-perl just
> > introduced by an update with 1.31-1. Upstream reference is found
> > here[2].
> > 
> >  [2]: https://github.com/dlc/text--tabulardisplay/commit/4b9bd105d9ebaf8ac838e8e993216e4b56d85683#commitcomment-1537151
> 
> then please reassign/affects as needed, and close this bug report in
> your changelog.

reassign/affects was already done, but added the bug closure as I
forgot it to do.

> > Updating now libtext-tabulardisplay-perl to 1.33 would fix the issue,
> > but I would like to ask first for approval of the debdiff.
> > 
> > The Changes file had missing entries only updated now, so the huge
> > diff there. The Uploads for 1.32 and 1.33 upstream updated too
> > respectively the testsuite, so the real changes reduces to only:
> > 
> >  TabularDisplay.pm |    9 +
> > 
> > Full diffstat:
> > 
> >  Changes           |  245 +++++++++++++++++++++++++++++++++++++++---------------
> >  MANIFEST          |    2 
> >  META.yml          |    2 
> >  README            |    3 
> >  TabularDisplay.pm |    9 +
> >  debian/changelog  |    7 +
> >  t/16.t            |   30 ++++++
> >  t/17.t            |   34 +++++++
> >  8 files changed, 260 insertions(+), 72 deletions(-)
> > 
> > Would that diff be accepted for a freeze-exception? Else I can prepare
> > an upload with only the fix to TabularDisplay.pm but having the
> > test-suite updated too would be fine.
> 
> Many thanks for the detailed analysis, that's appreciated. I like the
> idea of getting doc fixes and a better test suite along with the actual
> bug fix. Please upload to unstable (with the above-mentioned bug
> closure).

Thank you!

> > unblock libtext-tabulardisplay-perl/1.33-1
> 
> Please ping us back when the upload has happened. Will unblock after a
> final review of the uploaded package.

Just uploaded and accepted.

Regards,
Salvatore

Attachment: signature.asc
Description: Digital signature


Reply to: