Bug#680895: unblock: libtext-tabulardisplay-perl/1.33-1 (asking for pre-approval, package not uploaded yet)
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: freeze-exception
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hi Release-Team
It was reported a FTBFS with libtext-recordparser-perl [1].
[1]: http://bugs.debian.org/680831
But this actually is a bug in libtext-tabulardisplay-perl just
introduced by an update with 1.31-1. Upstream reference is found
here[2].
[2]: https://github.com/dlc/text--tabulardisplay/commit/4b9bd105d9ebaf8ac838e8e993216e4b56d85683#commitcomment-1537151
Updating now libtext-tabulardisplay-perl to 1.33 would fix the issue,
but I would like to ask first for approval of the debdiff.
The Changes file had missing entries only updated now, so the huge
diff there. The Uploads for 1.32 and 1.33 upstream updated too
respectively the testsuite, so the real changes reduces to only:
TabularDisplay.pm | 9 +
Full diffstat:
Changes | 245 +++++++++++++++++++++++++++++++++++++++---------------
MANIFEST | 2
META.yml | 2
README | 3
TabularDisplay.pm | 9 +
debian/changelog | 7 +
t/16.t | 30 ++++++
t/17.t | 34 +++++++
8 files changed, 260 insertions(+), 72 deletions(-)
Would that diff be accepted for a freeze-exception? Else I can prepare
an upload with only the fix to TabularDisplay.pm but having the
test-suite updated too would be fine.
unblock libtext-tabulardisplay-perl/1.33-1
Regards,
Salvatore
- -- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJP+gyrAAoJEHidbwV/2GP+l+cP/A+T1jH2zzaFlh9mV0gVExhF
0EyLIYfYoGA8IBQnM3KQSNr4B8GrizelUzH6znWsZsbe9KlgBo3OWKRk6+tKMPyH
PCJUcgg1qq6MifPubeyIh73biZzKWFn7zXCn3L/NHuhyN1s7p5puqttCl7LUnkOH
/T79DiACboEw5cwA1No68ZvYfjjsxNYH1bbPyW59nPxpilaQlZHc2MQwXnYRr1lN
UrAH7H/uvyYA3ApXKOxkGP3+6k/f1X03+dqFcerNDhBqa6wKiFCLoc1W4Erp4nTd
FiW5e2cAOpOjFnyqmKpKwmaO8NuLbL3hhIyNjaeXdWyEbPYTOnEvHoHZcwFlmSKB
8V9NI0izLGBDxLy+4HBXZrp6CBkw9wGUUhNCvzwpbB6aIJl1pqjyBvWUI0O03xBO
taFq6kkZsdz7lUtm8XTSqNwsFDrbFkRUcv7zbP0Ei+KmZJmsujOC/oBWmboMin18
bWMa+wRvhVJBHSG8c2c7lIl0bRZHfw3IGFBKO0YkZ1QVlHvH8eBWJkXXVSKBjbgF
scDu4vHzoqUN/Mg5Uz5zigdStDH0Ya7yMKYOf6artvKrjt9UDiFAs5Bqz4QJIsMn
ke1s+gM1LVD+tLd7zJ5tsIJQJKoZYACCkVoVu26OK5hSuPRgMfC3t3FJWZLf+HtE
haIVZCNELKEYXOYKPLN8
=dqiN
-----END PGP SIGNATURE-----
diff -Nru libtext-tabulardisplay-perl-1.31/Changes libtext-tabulardisplay-perl-1.33/Changes
--- libtext-tabulardisplay-perl-1.31/Changes 2012-03-30 15:18:21.000000000 +0200
+++ libtext-tabulardisplay-perl-1.33/Changes 2012-07-04 15:36:41.000000000 +0200
@@ -2,132 +2,245 @@
--- Text-TabularDisplay ---
======================================================================
-2004-10-20 16:28 dlc
+2012-07-04 Darren Chamberlain <darren@cpan.org>
+
+ * README, TabularDisplay.pm: Noted Patrick Kuijvenhoven as a
+ contributor for v1.32.
+
+2012-07-04 Darren Chamberlain <darren@cpan.org>
+
+ * README: Update docs for version 1.32.
+
+2012-07-04 Darren Chamberlain <darren@cpan.org>
+
+ * MANIFEST, t/16.t: Added a test for valid but non-true cell values.
+
+2012-07-04 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Ensure that valid but non-true values, like 0,
+ are handled correctly.
+
+2012-06-26 Darren Chamberlain <darren@cpan.org>
+
+ * README: Increment version number.
+
+2012-06-26 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Increment version number.
+
+2012-06-21 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Increment version number.
+
+2012-06-21 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Ensure that undefs are handled gracefully.
+
+2012-03-30 Darren Chamberlain <darren@cpan.org>
+
+ * README, TabularDisplay.pm: Add name to credits for pod typo fix.
+
+2012-03-30 Darren Chamberlain <darren@cpan.org>
+
+ * .gitignore: CPAN furniture.
+
+2012-03-30 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Bump version number and update copright date.
+
+2012-03-30 Darren Chamberlain <darren@cpan.org>
+
+ * README: RT76163: typos in pod
+
+2012-03-30 Darren Chamberlain <darren@cpan.org>
+
+ * .gitignore, COPYING, MANIFEST, META.yml: Stuff from 1.28 that
+ didn't get pulled into the repo.
+
+2012-03-30 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: RT76163: typos in pod
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * META.yml, TabularDisplay.pm: Final version bump.
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * README: Update README.
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Bump version number.
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * README: Update README from docs.
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Bump version number for new release.
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Make _add() a method call, so it can be
+ overridden. Specificallyt requested by Ranganath Achari
+ <ranganath.achari@gmail.com> so he can do some fancy overriding.
+
+2011-08-06 Darren Chamberlain <darren@cpan.org>
+
+ * MANIFEST, SIGNATURE: Remove SIGNATURE file.
+
+2008-04-22 Darren Chamberlain <darren@cpan.org>
+
+ * Makefile.PL, README, TabularDisplay.pm, examples/mysql.pl,
+ examples/tdisplay, t/01.t, t/02.t, t/03.t, t/04.t, t/05.t, t/06.t,
+ t/07.t, t/08.t, t/09.t, t/10.t, t/11.t, t/12.t, t/13.t, t/14.t,
+ t/15.t: Removed $Id$, $Date$, and $Revision$
+
+2008-04-22 Darren Chamberlain <darren@cpan.org>
+
+ * MANIFEST: Added MANIFEST.SKIP to MANIFEST
+
+2008-04-22 Darren Chamberlain <darren@cpan.org>
+
+ * MANIFEST.SKIP: Added .git to MANIFEST.SKIP.
+
+2005-12-09 Darren Chamberlain <darren@cpan.org>
+
+ * META.yml: Updated to 1.21
+
+2005-12-09 Darren Chamberlain <darren@cpan.org>
+
+ * TabularDisplay.pm: Applied patch from fischerdk@fidoki.com, in
+ response to RT#8952
+
+2004-10-20 16:28 Darren Chamberlain <darren@cpan.org>
* TabularDisplay (1.20): Applied a mutate agglomeration of a pair of
patches from Prakash Kailasa and Paul Cameron to address newline folding
within values, slightly modified according to suggestions from Slaven
Rezic.
-2004-09-21 09:14 dlc
+2004-09-21 09:14 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.19): Applied a patch from Eric Cholet to
silence warnings (<https://rt.cpan.org/Ticket/Display.html?id=7693>)
-2002-10-28 15:14 dlc
+2002-10-28 15:14 Darren Chamberlain <darren@cpan.org>
* README (1.6): Version updates.
-2002-10-25 00:10 dlc
+2002-10-25 00:10 Darren Chamberlain <darren@cpan.org>
* README (1.5): Updated.
-2002-10-25 00:10 dlc
+2002-10-25 00:10 Darren Chamberlain <darren@cpan.org>
* Changes (1.11): Automatically generated by cvs2cl.pl for
dlc@tumbleweed
-2002-10-25 00:10 dlc
+2002-10-25 00:10 Darren Chamberlain <darren@cpan.org>
* Makefile.PL (1.5): Using DISTVNAME and SUFFIX.
-2002-10-25 00:10 dlc
+2002-10-25 00:10 Darren Chamberlain <darren@cpan.org>
* MANIFEST (1.7): Added another example: tdisplay
-2002-10-25 00:08 dlc
+2002-10-25 00:08 Darren Chamberlain <darren@cpan.org>
* examples/mysql.pl (1.3): Added optional addition of
MySQL::Config. Changed username references to user, so that the
defaults in my.cnf could be used.
-2002-10-24 23:56 dlc
+2002-10-24 23:56 Darren Chamberlain <darren@cpan.org>
* examples/tdisplay (1.2): Hey, this is actually kind of useful.
Should this be one of the examples, or should it be an actual part
of the package?
-2002-10-24 23:29 dlc
+2002-10-24 23:29 Darren Chamberlain <darren@cpan.org>
* examples/tdisplay (1.1): Command-line script to display stuff as
tables.
-2002-10-24 18:26 dlc
+2002-10-24 18:26 Darren Chamberlain <darren@cpan.org>
* t/13.t (1.2): Updated test.
-2002-10-24 18:26 dlc
+2002-10-24 18:26 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.18): Added _SIZE. Does The Right Thing for
cases where the number of elements in the header is changed after
data is added. See t/13.t for more details, and an example of what
this actually means.
-2002-10-24 17:48 dlc
+2002-10-24 17:48 Darren Chamberlain <darren@cpan.org>
* README (1.4): Up-to-date README.
-2002-10-24 17:42 dlc
+2002-10-24 17:42 Darren Chamberlain <darren@cpan.org>
* Changes (1.10): Automatically generated by cvs2cl.pl for
dlc@tumbleweed
-2002-10-24 17:40 dlc
+2002-10-24 17:40 Darren Chamberlain <darren@cpan.org>
* t/14.t (1.1): Test for populate().
-2002-10-24 17:40 dlc
+2002-10-24 17:40 Darren Chamberlain <darren@cpan.org>
* examples/dump-passwd.pl (1.2): Removed alignment characters (no
longer applicable), and simplified the program a lot.
-2002-10-24 17:31 dlc
+2002-10-24 17:31 Darren Chamberlain <darren@cpan.org>
* MANIFEST (1.6): Added another test.
-2002-10-24 17:31 dlc
+2002-10-24 17:31 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.17): Added paginate() method.
-2002-10-16 07:04 dlc
+2002-10-16 07:04 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.16): populate unintentionally ate the array
it was passed; fixed. Added items method, which returns the number
of elements that the structure contains.
-2002-10-15 16:26 dlc
+2002-10-15 16:26 Darren Chamberlain <darren@cpan.org>
* examples/mysql.pl (1.2): Added command history (reads/writes to
~/.mysql_history).
-2002-10-15 16:21 dlc
+2002-10-15 16:21 Darren Chamberlain <darren@cpan.org>
* examples/aliases (1.2): Added -l to #! line.
-2002-10-15 16:21 dlc
+2002-10-15 16:21 Darren Chamberlain <darren@cpan.org>
* t/08.t (1.5): Removed alignment tests.
-2002-10-15 16:20 dlc
+2002-10-15 16:20 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.15): Silly diff: added ; to end of a line.
-2002-10-15 16:20 dlc
+2002-10-15 16:20 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.14): Moved Version() to beginning. Removed
references to _format_column, including definition. Removed _align
function: Alignment no longer exists.
-2002-10-09 07:19 dlc
+2002-10-09 07:19 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.12), TabularDisplay.pm (1.13): Gets version
from $Revision: 1.1 $.
-2002-10-09 07:18 dlc
+2002-10-09 07:18 Darren Chamberlain <darren@cpan.org>
* Makefile.PL (1.4): Uses TabularDisplay.pm for version.
-2002-10-09 07:14 dlc
+2002-10-09 07:14 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.11): Added _format_column function, which
formats the column names. Added _align function, which justifies
@@ -136,114 +249,114 @@
pragma, in a (potentially misguided) attempt to make division
faster. Updated documentation to reflect changes.
-2002-10-09 07:11 dlc
+2002-10-09 07:11 Darren Chamberlain <darren@cpan.org>
* MANIFEST (1.5): Added another example and another test.
-2002-10-09 07:11 dlc
+2002-10-09 07:11 Darren Chamberlain <darren@cpan.org>
* t/08.t (1.4): Readded test, with new contents.
-2002-10-09 07:05 dlc
+2002-10-09 07:05 Darren Chamberlain <darren@cpan.org>
* examples/dump-passwd.pl (1.1): Another example.
-2002-10-08 16:35 dlc
+2002-10-08 16:35 Darren Chamberlain <darren@cpan.org>
* t/08.t (1.3): Removed string overloading, so this test is not
relevent.
-2002-10-08 13:47 dlc
+2002-10-08 13:47 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.10): Clears _COLUMNS when new columns are
added.
-2002-10-08 13:46 dlc
+2002-10-08 13:46 Darren Chamberlain <darren@cpan.org>
* t/13.t (1.1): Test for column silliness, reported by "David N.
Blank-Edelman" <dnb@ccs.neu.edu>.
-2002-09-24 06:47 dlc
+2002-09-24 06:47 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.9): Automatically sets $VERSION
-2002-09-24 06:39 dlc
+2002-09-24 06:39 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.8), Makefile.PL (1.3): Incremented version
number for release.
-2002-09-24 06:38 dlc
+2002-09-24 06:38 Darren Chamberlain <darren@cpan.org>
* Changes (1.7), Changes (1.8), Changes (1.9): Automatically
generated by cvs2cl.pl for dlc@tumbleweed
-2002-09-24 06:38 dlc
+2002-09-24 06:38 Darren Chamberlain <darren@cpan.org>
* .todo (1.2): Marked documentation complete.
-2002-09-23 23:43 dlc
+2002-09-23 23:43 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.7): More VERSION stuff.
-2002-09-23 23:41 dlc
+2002-09-23 23:41 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.6): Added VERSION stuff.
-2002-09-23 23:39 dlc
+2002-09-23 23:39 Darren Chamberlain <darren@cpan.org>
* Changes (1.6): Automatically generated by cvs2cl.pl for
dlc@tumbleweed
-2002-09-23 23:39 dlc
+2002-09-23 23:39 Darren Chamberlain <darren@cpan.org>
* Makefile.PL (1.2): Updated $VERSION
-2002-09-23 23:35 dlc
+2002-09-23 23:35 Darren Chamberlain <darren@cpan.org>
* t/05.t (1.3): Changes to accomidate $start and $end additions to
render().
-2002-09-23 23:35 dlc
+2002-09-23 23:35 Darren Chamberlain <darren@cpan.org>
* README (1.3): Updated README
-2002-09-23 23:35 dlc
+2002-09-23 23:35 Darren Chamberlain <darren@cpan.org>
* Changes (1.4), Changes (1.5): Automatically generated by
cvs2cl.pl for dlc@tumbleweed
-2002-09-23 23:34 dlc
+2002-09-23 23:34 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.5): Added $start and $end to render();
documented them.
-2002-09-23 23:23 dlc
+2002-09-23 23:23 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.4): Some more documentation.
-2002-09-23 22:44 dlc
+2002-09-23 22:44 Darren Chamberlain <darren@cpan.org>
* MANIFEST (1.4): Added examples/mysql.pl; resorted
-2002-09-23 22:44 dlc
+2002-09-23 22:44 Darren Chamberlain <darren@cpan.org>
* examples/mysql.pl (1.1): Example mysql client, using
Text::TabularDisplay
-2002-09-23 18:15 dlc
+2002-09-23 18:15 Darren Chamberlain <darren@cpan.org>
* MANIFEST (1.3): Added examples and t/12.t
-2002-09-23 18:14 dlc
+2002-09-23 18:14 Darren Chamberlain <darren@cpan.org>
* README (1.2): Updated README.
-2002-09-23 18:12 dlc
+2002-09-23 18:12 Darren Chamberlain <darren@cpan.org>
* Changes (1.3): Automatically generated by cvs2cl.pl for
dlc@tumbleweed
-2002-09-23 18:12 dlc
+2002-09-23 18:12 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.3): Moved resetting to reset() and out of
columns(). columns() calls _add internally. add() calls _add
@@ -254,66 +367,66 @@
Updated documentation: documented reset(), populate(); removed
incorrect documentation for add() and columns().
-2002-09-23 18:09 dlc
+2002-09-23 18:09 Darren Chamberlain <darren@cpan.org>
* t/12.t (1.1): Tests adding columns after the fact.
-2002-09-23 18:08 dlc
+2002-09-23 18:08 Darren Chamberlain <darren@cpan.org>
* t/11.t (1.2): Modified add; no longer takes [ [], [], [], ]. Use
populate() instead. Updated test.
-2002-09-23 18:08 dlc
+2002-09-23 18:08 Darren Chamberlain <darren@cpan.org>
* t/03.t (1.3): Changes the way columns bahaves; updated tests.
-2002-09-23 18:07 dlc
+2002-09-23 18:07 Darren Chamberlain <darren@cpan.org>
* t/01.t (1.3): No real changes.
-2002-09-23 12:02 dlc
+2002-09-23 12:02 Darren Chamberlain <darren@cpan.org>
* TabularDisplay.pm (1.2): Added clone method. Added lots more
docs. Handles arrayrefs of arrayrefs.
-2002-09-23 12:01 dlc
+2002-09-23 12:01 Darren Chamberlain <darren@cpan.org>
* MANIFEST (1.2): Added tests 9, 10, and 11
-2002-09-23 07:09 dlc
+2002-09-23 07:09 Darren Chamberlain <darren@cpan.org>
* examples/aliases (1.1): Example usage.
-2002-09-23 06:49 dlc
+2002-09-23 06:49 Darren Chamberlain <darren@cpan.org>
* t/11.t (1.1): Test for passing arrays of arrays to add().
-2002-09-23 06:33 dlc
+2002-09-23 06:33 Darren Chamberlain <darren@cpan.org>
* t/10.t (1.1): Added test for add() chaining.
-2002-09-23 06:26 dlc
+2002-09-23 06:26 Darren Chamberlain <darren@cpan.org>
* t/: 01.t (1.2), 02.t (1.2), 03.t (1.2), 04.t (1.2), 05.t (1.2),
06.t (1.2), 07.t (1.2), 08.t (1.2): Added RCS Id strings.
-2002-09-23 06:26 dlc
+2002-09-23 06:26 Darren Chamberlain <darren@cpan.org>
* t/09.t (1.1): Added test for clone method.
-2002-09-23 06:15 dlc
+2002-09-23 06:15 Darren Chamberlain <darren@cpan.org>
* Changes (1.2): Automatically generated by cvs2cl.pl for
dlc@tumbleweed
-2002-09-23 06:15 dlc
+2002-09-23 06:15 Darren Chamberlain <darren@cpan.org>
* .todo (1.1), Changes (1.1), MANIFEST (1.1), Makefile.PL (1.1),
README (1.1), TabularDisplay.pm (1.1), t/01.t (1.1), t/02.t (1.1),
t/03.t (1.1), t/04.t (1.1), t/05.t (1.1), t/06.t (1.1), t/07.t
(1.1), t/08.t (1.1): Initial revision
-2002-09-23 06:15 dlc
+2002-09-23 06:15 Darren Chamberlain <darren@cpan.org>
* .todo (1.1.1.1), Changes (1.1.1.1), MANIFEST (1.1.1.1),
Makefile.PL (1.1.1.1), README (1.1.1.1), TabularDisplay.pm
diff -Nru libtext-tabulardisplay-perl-1.31/MANIFEST libtext-tabulardisplay-perl-1.33/MANIFEST
--- libtext-tabulardisplay-perl-1.31/MANIFEST 2012-03-30 15:18:21.000000000 +0200
+++ libtext-tabulardisplay-perl-1.33/MANIFEST 2012-07-05 14:47:04.000000000 +0200
@@ -23,5 +23,7 @@
t/13.t
t/14.t
t/15.t
+t/16.t
+t/17.t
TabularDisplay.pm
META.yml Module meta-data (added by MakeMaker)
diff -Nru libtext-tabulardisplay-perl-1.31/META.yml libtext-tabulardisplay-perl-1.33/META.yml
--- libtext-tabulardisplay-perl-1.31/META.yml 2012-06-21 17:51:20.000000000 +0200
+++ libtext-tabulardisplay-perl-1.33/META.yml 2012-07-05 19:17:01.000000000 +0200
@@ -1,6 +1,6 @@
--- #YAML:1.0
name: Text-TabularDisplay
-version: 1.31
+version: 1.33
abstract: ~
author: []
license: unknown
diff -Nru libtext-tabulardisplay-perl-1.31/README libtext-tabulardisplay-perl-1.33/README
--- libtext-tabulardisplay-perl-1.31/README 2012-03-30 15:24:11.000000000 +0200
+++ libtext-tabulardisplay-perl-1.33/README 2012-07-05 14:45:58.000000000 +0200
@@ -232,7 +232,8 @@
Prakash Kailasa
Slaven Rezic
Harlan Lieberman-Berg
+ Patrick Kuijvenhoven
VERSION
- This documentation describes "Text::TabularDisplay" version 1.30.
+ This documentation describes "Text::TabularDisplay" version 1.33.
diff -Nru libtext-tabulardisplay-perl-1.31/TabularDisplay.pm libtext-tabulardisplay-perl-1.33/TabularDisplay.pm
--- libtext-tabulardisplay-perl-1.31/TabularDisplay.pm 2012-06-21 17:50:46.000000000 +0200
+++ libtext-tabulardisplay-perl-1.33/TabularDisplay.pm 2012-07-05 14:43:14.000000000 +0200
@@ -23,7 +23,7 @@
use integer;
use vars qw($VERSION);
-$VERSION = "1.31";
+$VERSION = "1.33";
# ---======================= Public Methods ======================---
@@ -251,7 +251,7 @@
my $height = 0;
my @col_lines;
for (@$columns) {
- my @lines = split "\n" => ($_ || '');
+ my @lines = split "\n", ((defined $_ && length $_) ? $_ : ' ');
$height = scalar @lines
if $height < @lines;
push @col_lines, \@lines;
@@ -276,7 +276,7 @@
sub _column_length
{
my ($str) = @_;
- $str ||= '';
+ $str = '' unless defined $str;
my $len = 0;
for (split "\n", $str) {
@@ -552,8 +552,9 @@
Prakash Kailasa
Slaven Rezic
Harlan Lieberman-Berg
+ Patrick Kuijvenhoven
=head1 VERSION
-This documentation describes C<Text::TabularDisplay> version 1.30.
+This documentation describes C<Text::TabularDisplay> version 1.33.
diff -Nru libtext-tabulardisplay-perl-1.31/debian/changelog libtext-tabulardisplay-perl-1.33/debian/changelog
--- libtext-tabulardisplay-perl-1.31/debian/changelog 2012-06-24 15:48:26.000000000 +0200
+++ libtext-tabulardisplay-perl-1.33/debian/changelog 2012-07-09 00:24:30.000000000 +0200
@@ -1,3 +1,10 @@
+libtext-tabulardisplay-perl (1.33-1) unstable; urgency=low
+
+ * Team upload.
+ * Imported Upstream version 1.33
+
+ -- Salvatore Bonaccorso <carnil@debian.org> Mon, 09 Jul 2012 00:14:24 +0200
+
libtext-tabulardisplay-perl (1.31-1) unstable; urgency=low
* New upstream release
diff -Nru libtext-tabulardisplay-perl-1.31/t/16.t libtext-tabulardisplay-perl-1.33/t/16.t
--- libtext-tabulardisplay-perl-1.31/t/16.t 1970-01-01 01:00:00.000000000 +0100
+++ libtext-tabulardisplay-perl-1.33/t/16.t 2012-07-04 14:39:52.000000000 +0200
@@ -0,0 +1,30 @@
+#!/usr/bin/perl
+# vim: set ft=perl:
+# Test suggested by Patrick Kuijvenhoven <https://github.com/petski>
+# in https://github.com/dlc/text--tabulardisplay/commit/4b9bd105d9ebaf8ac838e8e993216e4b56d85683#commitcomment-1537151
+
+use strict;
+use Text::TabularDisplay;
+use Test;
+
+BEGIN {
+ plan tests => 1;
+}
+
+my @data = (
+ [0, "c"],
+ ["d", "e"],
+ [0, 0],
+ [0, "f"],
+);
+
+my $t = Text::TabularDisplay->new("a", "b");
+$t->populate([ @data ]);
+ok($t->render, "+---+---+
+| a | b |
++---+---+
+| 0 | c |
+| d | e |
+| 0 | 0 |
+| 0 | f |
++---+---+");
diff -Nru libtext-tabulardisplay-perl-1.31/t/17.t libtext-tabulardisplay-perl-1.33/t/17.t
--- libtext-tabulardisplay-perl-1.31/t/17.t 1970-01-01 01:00:00.000000000 +0100
+++ libtext-tabulardisplay-perl-1.33/t/17.t 2012-07-05 14:45:29.000000000 +0200
@@ -0,0 +1,34 @@
+#!/usr/bin/perl
+# vim: set ft=perl:
+# Test suggested by Patrick Kuijvenhoven <https://github.com/petski>
+# in https://github.com/dlc/text--tabulardisplay/commit/4b9bd105d9ebaf8ac838e8e993216e4b56d85683#commitcomment-1540416
+
+use strict;
+use Text::TabularDisplay;
+use Test;
+
+BEGIN {
+ plan tests => 1;
+}
+
+my @data = (
+ ["a", "b"],
+ ["", ""],
+ [undef, ""],
+ ["", undef],
+ [undef, undef],
+ [0, 0],
+);
+
+my $t = Text::TabularDisplay->new("a", "b");
+$t->populate([ @data ]);
+ok($t->render, "+---+---+
+| a | b |
++---+---+
+| a | b |
+| | |
+| | |
+| | |
+| | |
+| 0 | 0 |
++---+---+");
Reply to: