Julien Cristau <jcristau@debian.org> writes: > shouldn't the opts->port argument have been dropped? same in > reg_pear.c, hw_pear.c. Good point. But, while it's no long used, it shouldn't hurt anything, and in testing it all works fine... so I'm inclined to leave it alone for now. > funky indent... (and in a bunch of other places) Yes. > The hardcoding of vt 8 in the init script feels wrong as well, but I > guess that's not a regression. (It's going to clash with a display > manager that starts before it or in parallel.) Indeed. The package has been set up this way for years. This code is only likely to be installed on a server with a stable network configuration that's hosting one of the special hardware random number generators used by the project, and they don't tend to have displays, so in practice this isn't much of a problem. There's an option to build the program without the UI enabled, but I've never tried it, and that feels like a bigger change more suited for the next stable release cycle. Bdale
Attachment:
pgp3l2Qmxi1Sf.pgp
Description: PGP signature