[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: php-mdb2: fix for bug#571702 in squeeze?



Hi,

first things first: is it fixed in unstable? (I know you mentioned that
in your mail, but let's see where a basic check leads me)

http://bugs.debian.org/cgi-bin/version.cgi?width=;info=1;absolute=0;fixed=php-mdb2%2F2.5.0b3-0.1;height=;found=php-mdb2%2F2.5.0b2-1;package=php-mdb2;format=png;collapse=1;ignore_boring=0
looks very strange.

And indeed, looking at the current source package in unstable, there's
only a single entry in debian/changelog, what the hell?!

Thomas Goirand <zigo@debian.org> (08/05/2012):
> I'd like to apply the attached patch to php-mdb2 in Squeeze. Reasons:
> - Call by reference is deprecated in PHP 5.3 (and removed in PHP 5.4)
> - This fixes an issue in roundcube, which is widely used (especially the
> backports, which I also use in production)
> - This is a very small patch, which can't hurt anything. Call-time
> pass-by-reference is well documented, just removing the "&" solves it,
> and I don't think a mistake is possible.
> - Teodor MICU <mteodor@gmail.com> tested it, and me as well in production.
> - The same kind of fix is already in SID (modified upstream in the same
> way as the attached patch), with so far no problems reported upstream or
> in the Debian BTS.

You're supposed to send a source debdiff against the package currently
in stable, properly versioned.

As far as I'm concerned, I can't judge the impact of that PHP thingy.

> Let me know if it's ok to upload into squeeze-proposed-updates, for the
> next point release,

We froze this weekend, so it's certainly not OK for this point release.

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: