[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Proposed update to netselect in stable



Hi.

(Overriding M-F-T since I'm not sure you read this list, apologies if
that was set on purpose; on another note: fixing the Subject.)

Javier Fernández-Sanguino Peña <jfs@computer.org> (11/04/2012):
> In order to make netselect-apt functional for Squeeze users (see bugs #667985
> and #665876) I would like to upload a new netselect package to stable.

AFAICS that doesn't look too bad, even though it's almost 4am and I
shouldn't be reading debdiffs for stable; so you may want to wait until
somebody else checks this diff too.

> Please find attached a proposed diff (generated using interdiff) with the
> fixes that would be included in the new package. The code is also available
> in the Squeeze branch of netselect's SVN repository at svn.debian.org [1]

Minor nits below.

> The changes are already available in the Sid distribution and have been
> tested in a Squeeze chroot and dot not seem to introduce any new bugs.

Thanks for that.

> +.BR netselect-apt
> +is also unable to work in environments where HTTP or FTP network connections have to be
> +done through a proxy host, as it relies in being able to test the validity of the
                                           ^^
                                           on?

> +For Debian GNU/Linux it is recommended that users review the official mirror
> +list in http://www.debian.org/mirror/official, as well as the mirror checker
        ^^                                      ^
        at?       bonus points if you kill that comma, which can break copy/paste

> diff -u netselect-0.3.ds1/debian/changelog netselect-0.3.ds1/debian/changelog
> --- netselect-0.3.ds1/debian/changelog
> +++ netselect-0.3.ds1/debian/changelog
> @@ -1,3 +1,26 @@
> +netselect (0.3.ds1-14+squeeze1) stable; urgency=medium
> +
> +  * Backport fixes and documentation to Squeeze to fix grave bugs.
> +  * netselect-apt: 
> +    - modify regular expression to to parse newest mirrors list with
                                      ^^ -to

> +      rel="nofollow" in href links. Thanks to "Nameless" for the patch
> +      (Closes: #667985, #665876)
> +    - Make the script more robust by having it check and detect some common
> +      issues when running netselect: 
> +        * No hosts are found to use with netselect, due to an incorrect file
> +          being provided or an error when downloading the mirror list
> +      Now the script will at least abort with a (hopefully useful) error
> +      message instead of writting a useless sources.list (Closes: 238888)
                                ^                                   ^
                               -t                    (optionally:) +#

Mraw,
KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: