Re: Solving rdiff-backup bug in Squeeze
On Fri, 2011-09-16 at 20:20 +0100, Adam D. Barratt wrote:
> On Sat, 2011-03-12 at 14:16 +0000, Adam D. Barratt wrote:
> > On Sat, 2011-03-12 at 12:52 +0000, Carl Chenet wrote:
> > > The rdiff-backup version currently in Squeeze triggers an annoying
> > > Python deprecation warning message in some situations (bug #587370). A
> > > patch to solve this issue has been integrated in Ubuntu for some time
> > > and it also works for the Debian package pretty well.
> [...]
> > Judging from the bug log, it appears that this problem also affects the
> > package in unstable, and has not yet been fixed there? That's generally
> > a pre-requisite for getting the patch accepted for stable, as it means
> > the patch has been tested in Debian for at least a short time, allowing
> > any obvious issues to be ironed out.
>
> Ping? As far as I can tell, this is still outstanding in unstable.
So it looks like this was finally fixed in unstable.
Looking at the proposed diff, this change does make me slightly
paranoid:
+- process = subprocess.Popen(remote_cmd, shell=False, bufsize=0,
++ process = subprocess.Popen(remote_cmd, shell=True, bufsize=0,
Does "remote_cmd" ever include user-supplied (and unsanitised) data?
Regards,
Adam
Reply to: