On 01/11/2012 05:04 PM, in #655517, Daniel Kahn Gillmor wrote: > Package: gimp > Version: 2.6.10-1 > Severity: normal > Tags: patch > > When using version 1.10 or later of libcairo2 (e.g. from > mozilla.debian.net's squeeze-backports repository), gimp 2.6.10's > print and print preview are broken. > > In particular: the print preview window shows a blank page, and when > printing, a network printer appears to see a job coming in, but it > never produces a page. > > Upstream appears to have noticed as > https://bugzilla.gnome.org/show_bug.cgi?id=631199 and fixed this in > commit 6be41a6675007a0c7328453c654bcda5a2b875b0, which applies with a > bit of fuzz to 2.6.10-1. I'm attaching it (de-fuzzed) to this bug > report. What does the release team think about this patch for the next point release? If the GIMP maintainers are OK with it, i'm happy to prepare an NMU to squeeze-proposed-updates. I can verify that the patch does indeed fix the GIMP's printing problems for squeeze installations running iceweasel from mozilla.debian.net/squeeze-backports. Regards, --dkg
From c58dc682e6dbbcf2ad5eb162ae84e15f12ae74a1 Mon Sep 17 00:00:00 2001 From: Sven Neumann <sven@gimp.org> Date: Sun, 03 Oct 2010 12:05:20 +0000 Subject: Bug 631199 - Printing and Print preview broken with cairo 1.10 Add missing calls to cairo_surface_mark_dirty(). (cherry picked from commit 6be41a6675007a0c7328453c654bcda5a2b875b0) --- Index: gimp-2.6.10/plug-ins/print/print-draw-page.c =================================================================== --- gimp-2.6.10.orig/plug-ins/print/print-draw-page.c 2010-07-02 18:51:59.000000000 -0400 +++ gimp-2.6.10/plug-ins/print/print-draw-page.c 2012-01-11 15:41:07.000000000 -0500 @@ -240,6 +240,8 @@ gimp_drawable_detach (drawable); + cairo_surface_mark_dirty (surface); + return surface; } Index: gimp-2.6.10/plug-ins/print/print-preview.c =================================================================== --- gimp-2.6.10.orig/plug-ins/print/print-preview.c 2010-07-02 18:51:59.000000000 -0400 +++ gimp-2.6.10/plug-ins/print/print-preview.c 2012-01-11 15:41:07.000000000 -0500 @@ -864,5 +864,7 @@ g_free (data); + cairo_surface_mark_dirty (surface); + return surface; }
Attachment:
signature.asc
Description: OpenPGP digital signature