Bug#614249: britney2: insufficient removal checks

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

On Sun, 2011-02-20 at 17:20 +0000, Adam D. Barratt wrote:
> britney1 and britney2 have different methods of determining whether a
> package can be removed from testing, which recently led to britney2
> removing a package when it shouldn't have.  A patch which appears to fix
> this is attached, the remainder of this mail is discussion of what
> happened and why I believe the patch is correct.
[...]
> My patch augments step a by storing a recursive list of r-depends for
> later consideration; in this case this would mean that Q is checked in
> step b and discovered to be uninstallable.
[...]
> Comments / questions / cluesticks welcome.

Self-cluestick: b2 already has a get_full_tree method which iterates
reverse-dependency lists, so we should just use that.  Updated patch
coming to a b2 tree near you soon.

Regards,

Adam