Bug#622152: [britney2] Port to python2.6 (s/PyFoo_Check/PyFoo_CheckExact/)

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

tag 622152 + moreinfo
thanks

On Sun, 2011-04-10 at 15:36 +0200, Mehdi Dogguy wrote:
> It seems that britney2 segfaults at every run when compiled for Python
> 2.6. After some quick investigation, the problem boils down to the
> following:
> 
> Britney2 uses PyFoo_Check to check that some structure has the correct
> type. That class of functions changed between Python 2.5 and 2.6. The
> (relevant part of the) diff is as follows:
[...]
> Attached is a simple patch that performs the described substitution.
> Using this patch, I've been able to run britney2 on my machines
> wihtout seeing any problem.

I've finally (!) got to looking at this but have been unable to
reproduce the problem.  It might be a squeeze versus wheezy issue or
some oddity which has resolved itself in the meantime, but after
s/python2.5/python2.6/ in britney-py.c and rebuilding the library on
franck, everything seems to just work[tm].

If I don't change the shebang of britney herself then I do get this:

Traceback (most recent call last):
  File "./britney.py", line 2808, in <module>
    Britney().main()
  File "./britney.py", line 261, in __init__
    self.build_systems(arch)
  File "./britney.py", line 403, in build_systems
    self.systems[a] = buildSystem(a, packages)
SystemError: error return without exception set

but not a segfault.  Running the script  explicitly with python2.6 seems
to work okay in my test runs.

Regards,

Adam