[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#587315: 'multipath: unknown hardware handler type' with hardware_handler "1 hp-sw"



Hello Release Team,

I would like to propose an update to the multipath-tools package for
Squeeze. This proposed upload fixes 2 issues:

* [b5f7694] Change HP hardware hanlder to hp_sw.
    Thanks to Phil (Closes: 587315)
* [4aae2ad] Update man pages (Closes: 644913)


Attached the the debdiff against the previous version in squeeze. I've
built it on my Squeeze pbuilder.


Ritesh


On 10/15/2011 12:37 PM, Ritesh Raj Sarraf wrote:
> Please don't do an upload only with this fix. There are 2 more bug
> reports that I'd like to see fixed for stable-proposed-updates.
> 
> Bug#644913: multipath-tools: manpage out of date
> Bug#645247: multipath-tools: output from `multipath -lld' does not
> separate fields
> 
> 
> 
> 
> On Wednesday, October 5, 2011, Ritesh Raj Sarraf wrote:
> 
>     I'm currently maintaining multipath-tools.
>     The best would be to just fix this particular bug.
> 
>     sent from a Smartph0ne... excuse typ0s
> 
>     On Oct 3, 2011 11:06 PM, "Thijs Kinkhorst" <thijs@uvt.nl
>     <javascript:_e({}, 'cvml', 'thijs@uvt.nl');>> wrote:
>     >
>     > Hi Guido et al.,
>     >
>     >> thanks for your report. The issue is fixed upstream. I'd like to get
>     >> 0.4.9 into Sqeeze which has this patch.
>     >
>     > Unfortunately this version apparently didn't make it into Squeeze
>     at the
>     > time.
>     > Are you willing to provide a stable update for squeeze to address this
>     > bug?
>     >
>     > I'm also available to create an NMU for stable-proposed-updates
>     with just
>     > this
>     > fix for you if you don't have the time; let me know.
>     >
>     >
>     > Cheers,
>     > Thijs
>     >
>     > --
>     > Thijs Kinkhorst <thijs@uvt.nl <javascript:_e({}, 'cvml',
>     'thijs@uvt.nl');>> – LIS Unix
>     >
>     > Universiteit van Tilburg – Library and IT Services
>     > Bezoekadres > Warandelaan 2 • Tel. 013 466 3035 • G 236
>     >
>     >
>     >
> 
> 
> 
> -- 
> Ritesh Raj Sarraf
> RESEARCHUT - http://www.researchut.com
> "Necessity is the mother of invention."


-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System
diff -Nru multipath-tools-0.4.8+git0.761c66f/debian/changelog multipath-tools-0.4.8+git0.761c66f/debian/changelog
--- multipath-tools-0.4.8+git0.761c66f/debian/changelog	2011-10-31 12:37:06.000000000 +0530
+++ multipath-tools-0.4.8+git0.761c66f/debian/changelog	2011-10-30 23:57:47.000000000 +0530
@@ -1,3 +1,11 @@
+multipath-tools (0.4.8+git0.761c66f-10) stable-proposed-updates; urgency=low
+
+  * [b5f7694] Change HP hardware hanlder to hp_sw.
+    Thanks to Phil (Closes: 587315)
+  * [4aae2ad] Update man pages (Closes: 644913)
+
+ -- Ritesh Raj Sarraf <rrs@debian.org>  Sun, 30 Oct 2011 23:54:39 +0530
+
 multipath-tools (0.4.8+git0.761c66f-9) unstable; urgency=low
 
   * [0435cc1] Make sure the patchcheckers end up in /lib (Closes: #581377)
diff -Nru multipath-tools-0.4.8+git0.761c66f/debian/patches/0012-hp-hardware-handler.patch multipath-tools-0.4.8+git0.761c66f/debian/patches/0012-hp-hardware-handler.patch
--- multipath-tools-0.4.8+git0.761c66f/debian/patches/0012-hp-hardware-handler.patch	1970-01-01 05:30:00.000000000 +0530
+++ multipath-tools-0.4.8+git0.761c66f/debian/patches/0012-hp-hardware-handler.patch	2011-10-30 23:52:42.000000000 +0530
@@ -0,0 +1,23 @@
+changes default hardware handler to hp_sw from hp-sw. This change has already been done upstream in 2009
+Index: multipath-tools/libmultipath/hwtable.c
+===================================================================
+--- multipath-tools.orig/libmultipath/hwtable.c	2011-10-30 12:37:27.902672064 +0530
++++ multipath-tools/libmultipath/hwtable.c	2011-10-30 12:40:22.942007814 +0530
+@@ -85,7 +85,7 @@
+ 		.product       = "HSG80",
+ 		.getuid        = DEFAULT_GETUID,
+ 		.features      = "1 queue_if_no_path",
+-		.hwhandler     = "1 hp-sw",
++		.hwhandler     = "1 hp_sw",
+ 		.selector      = DEFAULT_SELECTOR,
+ 		.pgpolicy      = GROUP_BY_PRIO,
+ 		.pgfailback    = FAILBACK_UNDEF,
+@@ -116,7 +116,7 @@
+ 		.product       = "(MSA|HSV)1.0.*",
+ 		.getuid        = DEFAULT_GETUID,
+ 		.features      = "1 queue_if_no_path",
+-		.hwhandler     = "1 hp-sw",
++		.hwhandler     = "1 hp_sw",
+ 		.selector      = DEFAULT_SELECTOR,
+ 		.pgpolicy      = GROUP_BY_PRIO,
+ 		.pgfailback    = FAILBACK_UNDEF,
diff -Nru multipath-tools-0.4.8+git0.761c66f/debian/patches/0013-manpage-updates.patch multipath-tools-0.4.8+git0.761c66f/debian/patches/0013-manpage-updates.patch
--- multipath-tools-0.4.8+git0.761c66f/debian/patches/0013-manpage-updates.patch	1970-01-01 05:30:00.000000000 +0530
+++ multipath-tools-0.4.8+git0.761c66f/debian/patches/0013-manpage-updates.patch	2011-10-30 23:52:42.000000000 +0530
@@ -0,0 +1,137 @@
+update outdated man pages
+Index: multipath-tools/multipath/multipath.conf.5
+===================================================================
+--- multipath-tools.orig/multipath/multipath.conf.5	2011-10-30 12:53:59.848537829 +0530
++++ multipath-tools/multipath/multipath.conf.5	2011-10-30 13:15:57.859988867 +0530
+@@ -124,30 +124,48 @@
+ to the device name, a '%b' will be expanded to the device number in
+ .I major:minor
+ format.
++.B prio
++The name of the path priority routine. The specified routine
++should return a numeric value specifying the relative priority
++of this path. Higher number have a higher priority.
+ .I "none"
+-is a valid value. Currently the following path priority programs are
++is a valid value. Currently the following path priority routines are
+ implemented:
+ .RS
+ .TP 12
+-.B mpath_prio_emc /dev/%n
+-Generate the path priority for EMC arrays
++.B const
++Return a constant priority of \fI1\fR.
+ .TP
+-.B mpath_prio_alua /dev/%n
++.B emc
++Generate the path priority for EMC arrays.
++.TP
++.B alua
+ Generate the path priority based on the SCSI-3 ALUA settings.
+ .TP
+-.B mpath_prio_netapp /dev/%n
++.B ontap
+ Generate the path priority for NetApp arrays.
+ .TP
+-.B mpath_prio_rdac /dev/%n
++.B rdac
+ Generate the path priority for LSI/Engenio RDAC controller.
+ .TP
+-.B mpath_prio_hp_sw /dev/%n
++.B hp_sw
+ Generate the path priority for Compaq/HP controller in
+ active/standby mode.
+ .TP
+-.B mpath_prio_hds_modular %b
++.B hds
+ Generate the path priority for Hitachi HDS Modular storage arrays.
+ .TP
++.B random
++Generate a random priority between 1 and 10.
++.TP 12
++.B weightedpath <hbtl|devname> <regex1> <prio1> <regex2> <prio2> ...
++.I hbtl 
++regex can be of SCSI H:B:T:L format  Ex: 1:0:.:. , *:0:0:.
++.I devname 
++regex can be of device name format  Ex: sda , sd.e
++Generate the path priority based on the regular expression and the 
++priority provided as argument.
++.TP
+ Default value is \fBnone\fR.
+ .RE
+ .TP
+@@ -165,7 +183,8 @@
+ .RS
+ .TP 12
+ .B readsector0
+-Read the first sector of the device
++(Deprecated) Read the first sector of the device. This checker is being
++deprecated, please use \fIdirectio\fR instead
+ .TP
+ .B tur
+ Issue a
+@@ -185,7 +204,7 @@
+ .B directio
+ Read the first sector with direct I/O.
+ .TP
+-Default value is \fIreadsector0\fR.
++Default value is \fIdirectio\fR.
+ .RE
+ .TP
+ .B failback
+@@ -318,6 +337,8 @@
+ .TP
+ .B path_selector
+ .TP
++.B prio
++.TP
+ .B failback
+ .TP
+ .B no_path_retry
+@@ -353,6 +374,16 @@
+ .TP 12
+ .B 1 emc
+ Hardware handler for EMC storage arrays.
++.TP
++.B 1 rdac
++Hardware handler for LSI/Engenio RDAC storage controller.
++.TP
++.B 1 hp_sw
++Hardware handler for Compaq/HP storage arrays in active/standby
++mode.
++.TP
++.B 1 alua
++Hardware handler for SCSI-3 ALUA compatible arrays.
+ .RE
+ .LP
+ The following attributes are optional; if not set the default values
+@@ -371,6 +402,8 @@
+ .TP
+ .B path_checker
+ .TP
++.B prio
++.TP
+ .B features
+ .TP
+ .B prio_callout
+@@ -394,6 +427,20 @@
+ It is advisable to use the
+ .B no_path_retry
+ option instead.
++.P
++The use of
++.B queue_if_no_path
++or
++.B no_path_retry
++might lead to a deadlock if the
++.B dev_loss_tmo
++setting results in a device being removed while I/O is still queued.
++The multipath daemon will update the
++.B dev_loss_tmo
++setting accordingly to avoid this deadlock. Hence if both values are
++specified the order of precedence is
++.I no_path_retry, queue_if_no_path, dev_loss_tmo
++
+ .SH "SEE ALSO"
+ .BR udev (8),
+ .BR dmsetup (8)
diff -Nru multipath-tools-0.4.8+git0.761c66f/debian/patches/series multipath-tools-0.4.8+git0.761c66f/debian/patches/series
--- multipath-tools-0.4.8+git0.761c66f/debian/patches/series	2011-10-31 12:37:06.000000000 +0530
+++ multipath-tools-0.4.8+git0.761c66f/debian/patches/series	2011-10-30 23:52:42.000000000 +0530
@@ -9,3 +9,5 @@
 0009-explicitly-include-posix_types.h.patch
 0010-Dots-are-special-in-groff.patch
 0011-multipath-fix-offset-for-containted-slices.patch
+0012-hp-hardware-handler.patch
+0013-manpage-updates.patch

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: