Bug#630251: [Fwd: Bug#630251: patch for proposed updates / rdesktop sometimes fails to transfer files from win2k8]
Hi Adam,
On Mon, 2011-06-13 at 20:48 +0100, Adam D. Barratt wrote:
> On Sun, 2011-06-12 at 20:09 +0200, Andreas Barth wrote:
> > some programms make rdesktop to fail to keep up the directory
> > forwarding to an win 2k8-server. Please see
> > http://sourceforge.net/tracker/?func=detail&aid=2812158&group_id=24366&atid=381349
> > for the bug, the fix is as follows:
> >
> > --- rdesktop-1.6.0.orig/disk.c 2009-06-19 09:06:27.000000000 -0400
> > +++ rdesktop-1.6.0/disk.c 2009-06-25 09:40:44.000000000 -0400
> > @@ -1096,10 +1101,24 @@
> [...]
>
> This is nearly, but not quite, the same as the corresponding code in the
> current rdesktop package in unstable. Other than the printf(), the
> difference is that where the proposed fix has:
>
> > + out_uint32_le(out, stat_fs.f_blocks); /* TotalAllocationUnits */
> > + out_uint32_le(out, 0);
> > + out_uint32_le(out, stat_fs.f_bavail); /* CallerAvailableAllocationUnits */
> > + out_uint32_le(out, 0);
>
> the package in unstable has:
>
> out_uint32_le(out, stat_fs.f_blocks); /* Total allocation units low */
> out_uint32_le(out, 0); /* Total allocation units high */
> out_uint32_le(out, stat_fs.f_blocks); /* Caller allocation units low */
> out_uint32_le(out, 0); /* Caller allocation units high */
>
> I've CCed the rdesktop maintainers for any comments they might have.
IMHO the former one is the correct, the changes in unstable seem to
have a copy&paste bug. stat_fs.f_blocks may has nothing to do with
'caller allocation units low'. Will ask upstream soon.
Laszlo/GCS
Reply to: