[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Request for update to fix dchroot-dsa bug in stable (#626503)



On Thu, May 12, 2011 at 02:09:10PM +0100, Roger Leigh wrote:
> Hi,
> 
> I was informed today that dchroot-dsa was non-functional in stable,
> and the same bug is also present in unstable.  I filed this as
> #626503.  The patch is a one-liner to fix a regression in the
> dchroot.conf conffile loading (the interface changed incompatibly
> prior to squeeze being released, and this code is still using the
> older interface, which results in a fatal exception being thrown).
> 
> dchroot-dsa can load both dchroot.conf for compatibility, and
> schroot.conf; presumably testing was with schroot.conf only which
> is why this was not picked up prior to release.
> 
> Would it be OK to upload a fixed version of the schroot package
> to stable-proposed-updated containing just this one line fix?

This is the patch:

index c2aa219..86e127d 100644
--- a/bin/dchroot-dsa/dchroot-dsa-main.cc
+++ b/bin/dchroot-dsa/dchroot-dsa-main.cc
@@ -61,7 +61,7 @@ main::load_config ()
       this->config =
        sbuild::chroot_config::ptr(new dchroot_dsa::chroot_config);
       if (this->options->load_chroots == true)
-       this->config->add(DCHROOT_CONF, false);
+       this->config->add("chroot", DCHROOT_CONF);
     }
   else
     {

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.

Attachment: signature.asc
Description: Digital signature


Reply to: