Re: Fwd: Bug#616482: strongswan-ikev1: virtual ips not released if xauth name does not match id
On Wed, 2011-04-06 at 21:46 +0200, René Mayrhofer wrote:
> I have now integrated the cherry-picked upstream patch into my
> strongswan-sqeeze branch at the alioth git repository
> (ssh://alioth.debian.org/git/pkg-swan/strongswan.git). As mentioned in
> the bug report, it applies cleanly and is an isolated fix for a bug in
> version 4.4.1 that impacts some clients.
It looks like we managed to miss this when it was originally sent;
apologies for that. However, a lack of response should only be treated
as that, not as an implicit ack for an upload.
Having spotted that you've uploaded already, I do have a few questions
about the upload.
Why have the configure options in debian/rules been modified, with no
mention of this in the changelog? So far as I can see, --enable-pkcs11,
--enable-eap-tls, --enable-eap-ttls and --enable-led have been added.
The addition of "--enable-nat-transport" /is/ mentioned in the
changelog, but was not mentioned in your mail to -release.
There are also several other changes related to the removal and
re-enabling under certain circumstances of the Network Manager support.
The associated comments indicate that this change was intended to ease
backports, so I'm not sure why this is being included in a stable
update; again, these changes are not mentioned in the changelog.
Furthermore, the n-m changes are actually buggy:
+ CONFIGUREARS += --enable-nm
That should presumably be CONFIGUREAR*G*S.