[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Proposed upload for fixing 613648 (in stable)

On Sat, Mar 12, 2011 at 02:10:23PM +0000, Adam D. Barratt wrote:
> On Sat, 2011-03-12 at 14:49 +0100, Iustin Pop wrote:
> > I would like to upload a fixed ganeti package in order to close #613648
> > (very stupid bug, sorry). Attached are the proposed changes, as
> > formatted with git format-patch on top of our git tree (change not
> > pushed yet). I confirm that the patch fixes the problem and that basic
> > functionality has been tested for the updated package.
> Why is ganeti changing the permissions of /var/lock at all?  (Rather
> than a file within that directory, or a sub-directory if need be).

That's a bug by itself; however, for stable, I'd rather just fix the

If you think it's better to fix it as to not touch /var/lock, that can
be done, but it'll be a slightly bigger patch.

> > It's a long time since I did a stable fix, so I might have gotten the
> > distribution or the versioning wrong; please let me know!
> Looking at the bug log, it appears that this also affects unstable, and
> has not yet been fixed there.  Is that correct?

It has been fixed, as the version in unstable uses /bin/chmod, not
Python's os.chmod. /bin/chmod always takes octal, so chmod 1777 is a
right call.

The fact that ganeti from unstable still touches /var/lock (at all) is
indeed a bug, that will be fixed separately.

Let me know how to proceed.


Attachment: signature.asc
Description: Digital signature

Reply to: