Re: Bug#610461: trac-mercurial bug
On Sat, January 22, 2011 23:36, Christoph Egger wrote:
> Hi!
>
> Jürgen A. Erhard <jae@jaerhard.com> writes:
>> This is from a hgwebdir install (dev.jaerhard.com). And it appears
>> it's "fixed" when the repo has owner www-data:www-data. The repo has
>> 644 perms throughout (+x for directories). So, it appears it needs
>> write permissions. Strange.
[...]
>> I applied the patch in @9943 (referenced in
>> http://trac.edgewall.org/ticket/9482) and that fixes it.
>
> Yeah I see how adding that will fix the crash at hand.I could just
> apply this -- does just adding tyhe **opts also fix your problem? That
> would just make these functions accept a bit nore different input and
> won't break anything working if I see that correctly so I could build a
> package with that patch attached if the release team prefers as I'm not
> sure we'll find the real problem before release.
Adding the **opts parameter does indeed look like it would resolve the
crash. I'm not familiar enough with trac to know if the other parts of
the referenced changeset are at all relevant, but the fact that the
permissions change "fixes" the issue (presumably by avoiding the call to
write_err() which fails) does suggest that they're not.
Regards,
Adam
Reply to: