Bug#609210: liblocal-lib-perl/1.006005-1+squeeze1 for testing-proposed-updates fixing #609192
Package: release.debian.org
Severity: normal
Hi release team
When building liblocal-lib-perl without having access to the home
directory of the building user liblocal-lib-perl in squeeze FTBFS.
The version in unstable is not affected. I prepared a backport from
the Makefile.PL there. Attached is the debdiff for the t-p-u upload.
See: http://bugs.debian.org/609192
Could you accept this into t-p-u?
Thanks in advance and for your work.
Bests
Salvatore
-- System Information:
Debian Release: 6.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
diff -Nru liblocal-lib-perl-1.006005/debian/changelog liblocal-lib-perl-1.006005/debian/changelog
--- liblocal-lib-perl-1.006005/debian/changelog 2010-07-14 18:03:02.000000000 +0200
+++ liblocal-lib-perl-1.006005/debian/changelog 2011-01-07 12:12:55.000000000 +0100
@@ -1,3 +1,12 @@
+liblocal-lib-perl (1.006005-1+squeeze1) testing-proposed-updates; urgency=low
+
+ * Update my email address.
+ * Patch Makefile.PL with fix-ftbfs-609192.patch to avoids CPAN client
+ configuration when not required which causes FTBFS if building user
+ home directory is not writeable (Closes: #609192).
+
+ -- Salvatore Bonaccorso <carnil@debian.org> Fri, 07 Jan 2011 09:36:54 +0100
+
liblocal-lib-perl (1.006005-1) unstable; urgency=low
* New upstream release
diff -Nru liblocal-lib-perl-1.006005/debian/control liblocal-lib-perl-1.006005/debian/control
--- liblocal-lib-perl-1.006005/debian/control 2010-07-14 18:03:02.000000000 +0200
+++ liblocal-lib-perl-1.006005/debian/control 2011-01-07 12:12:55.000000000 +0100
@@ -5,7 +5,7 @@
Build-Depends-Indep: perl (>= 5.10), libcapture-tiny-perl
Maintainer: Debian Perl Group <pkg-perl-maintainers@lists.alioth.debian.org>
Uploaders: Jonathan Yu <jawnsy@cpan.org>, gregor herrmann <gregoa@debian.org>,
- Salvatore Bonaccorso <salvatore.bonaccorso@gmail.com>
+ Salvatore Bonaccorso <carnil@debian.org>
Standards-Version: 3.9.0
Homepage: http://search.cpan.org/dist/local-lib/
Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/liblocal-lib-perl/
diff -Nru liblocal-lib-perl-1.006005/debian/patches/fix-ftbfs-609192.patch liblocal-lib-perl-1.006005/debian/patches/fix-ftbfs-609192.patch
--- liblocal-lib-perl-1.006005/debian/patches/fix-ftbfs-609192.patch 1970-01-01 01:00:00.000000000 +0100
+++ liblocal-lib-perl-1.006005/debian/patches/fix-ftbfs-609192.patch 2011-01-07 12:29:17.000000000 +0100
@@ -0,0 +1,86 @@
+Description: Fix FTBFS when homedirectory of building user is not
+ writeable.
+Origin: vendor
+Bug-Debian: http://bugs.debian.org/609192
+Forwarded: no
+Author: Salvatore Bonaccorso <carnil@debian.org>
+Reviewed-by: Salvatore Bonaccorso <carnil@debian.org>
+Last-Update: 2011-01-07
+
+--- a/Makefile.PL
++++ b/Makefile.PL
+@@ -92,7 +92,8 @@
+ my $cpan = $? >> 8;
+ my $cpan_command = '';
+
+- system($^X, '-MCPAN', '-e',
++ my $did_cpan_config = 0;
++ my $cpan_config_command =
+ 'my $done; require ExtUtils::MakeMaker;
+ my $orig = ExtUtils::MakeMaker->can("prompt");
+ *ExtUtils::MakeMaker::prompt = sub ($;$) {
+@@ -121,8 +122,7 @@
+ delete @{$CPAN::Config}{keys %$CPAN::Config};
+ $CPAN::Config->{urllist} = $save;
+ CPAN::Config->init;
+- }'
+- );
++ }';
+
+ $ENV{PERL_MM_USE_DEFAULT} = 1;
+
+@@ -138,6 +138,8 @@
+ $cpan_command .= 'force("install","CPAN"); ';
+ }
+ if(length $cpan_command) {
++ system($^X, '-MCPAN', '-e', $cpan_config_command);
++ $did_cpan_config++;
+ system($^X, '-MCPAN', '-e', $cpan_command);
+ }
+ if ($cpan) {
+@@ -147,6 +149,8 @@
+ # if we call this code directly, the changes get written to
+ # $BOOTSTRAP/lib/perl5/CPAN/Config.pm, not where the user expects them to
+ # be in their ~/.cpan/CPAN/MyConfig.pm.
++ system($^X, '-MCPAN', '-e', $cpan_config_command)
++ unless $did_cpan_config;
+ system($^X, '-MCPAN',
+ '-e',
+ q[CPAN::HandleConfig->load;],
+@@ -200,25 +204,27 @@
+ # It will already be installed by the time we reach here if bootstrapping,
+ # otherwise, if we're running from CPAN then it will be installed soon
+ # enough, and we'll come back here..
+- if (!$@) {
+- CPAN::HandleConfig->load;
+- for my $eumm_setting ( qw/makepl_arg make_install_arg/ ) {
+- if ($CPAN::Config->{$eumm_setting} =~ /(?:PREFIX|INSTALL_BASE)/) {
+- die <<"DEATH";
++ if (!$@ ) {
++ CPAN::HandleConfig->require_myconfig_or_config;
++ if ( $CPAN::Config ) {
++ for my $eumm_setting ( qw/makepl_arg make_install_arg/ ) {
++ if ($CPAN::Config->{$eumm_setting} =~ /(?:PREFIX|INSTALL_BASE)/) {
++ die <<"DEATH";
+ WHOA THERE! It looks like you've got $CPAN::Config->{$eumm_setting} set. This is
+ known to cause problems with local::lib. Please either remove this setting or
+ clear out your .cpan directory.
+ DEATH
++ }
+ }
+- }
+
+- for my $mb_setting (qw/mbuild_arg mbuild_install_arg mbuildpl_arg/) {
+- if ($CPAN::Config->{$mb_setting} =~ /(?:--prefix|--install_base)/) {
+- die <<"DEATH";
++ for my $mb_setting (qw/mbuild_arg mbuild_install_arg mbuildpl_arg/) {
++ if ($CPAN::Config->{$mb_setting} =~ /(?:--prefix|--install_base)/) {
++ die <<"DEATH";
+ WHOA THERE! It looks like you've got $CPAN::Config->{$mb_setting} set. This is
+ known to cause problems with local::lib. Please either remove this setting or
+ clear out your .cpan directory.
+ DEATH
++ }
+ }
+ }
+ }
diff -Nru liblocal-lib-perl-1.006005/debian/patches/series liblocal-lib-perl-1.006005/debian/patches/series
--- liblocal-lib-perl-1.006005/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ liblocal-lib-perl-1.006005/debian/patches/series 2011-01-07 12:12:55.000000000 +0100
@@ -0,0 +1 @@
+fix-ftbfs-609192.patch
Reply to: