[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

freeze exception for maildir-utils 0.7-2



Dear release managers,

I know o is late in the release cycle but I would like to get
two very small fixes into squeeze for maildir-utils:

The changes are as follows:
* fix broken search of msgids, patch by Benjamin Mako Hill
  (closes: #601072) (included upstream)

This change, implemented with quilt patch 
	debian/patches/fix-msgid-search
is a simple one-liner that is already included upstream. The quilt 
patch contains the description:
---- taken from the quilt patch or the original email ----
To reproduce the bug, try to output the message-id for any message in
the system using the field option to 'mu find' like:

  mu find -f i EXAMPLE

The result will not shown any message-ids but will just repeat the
letter "i". The problem seems to be that that message-id is being stored
as a Xapian term but not as a value. As a result, it can be searched
for, but not displayed.

I'm attaching a patch that solves the problem on my system. I don't know
the codebase well enough to know if I've fixed in this in "the right way."
----------------------------------------------------------

Response from upstream on the tracker:
	thanks! added the fix right in time for 0.8-beta.

The patch itself is a oneliner:
--- maildir-utils.git.orig/src/mu-msg-fields.c  2010-10-23 16:51:22.000000000 +0900
+++ maildir-utils.git/src/mu-msg-fields.c       2010-10-23 16:51:49.000000000 +0900
@@ -130,7 +130,7 @@
                MU_MSG_FIELD_ID_MSGID,
                MU_MSG_FIELD_TYPE_STRING,
                "msgid", "i", "I",  /* 'i' for Id */
-               FLAG_GMIME | FLAG_XAPIAN_TERM
+               FLAG_GMIME | FLAG_XAPIAN_TERM | FLAG_XAPIAN_VALUE
        },
        
        { 



* fix clearing of symlinks, patch by Antonin Kral (upstream issue 28)
  (closes: #578806)

this change is implemented as quilt patch
	debian/patches/fix-clearlinks
and a description from the original bug report and upstream issue
is included in the patch:
-----------------------------------------------
I have problem with --clearlinks which doesn't seem to do anything.
The symlinks in the result directory was never removed. I have found 
the same issue reported in Debian: 
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578806

I believe that the problem is in readdir_with_stat_fallback() function 
which was constantly returning DT_REG and not DT_LNK. You are using 
stat() call, which will follow the symlink, so the resolut will never be 
DT_LNK. The fix is simply to call lstat() instead:
------------------------------------

I confirm myself that the fix changes the behaviour to that described
in the man page.

The patch itself is a one-liner again:
--- maildir-utils.git.orig/src/mu-maildir.c     2010-11-02 00:06:04.000000000 +0900
+++ maildir-utils.git/src/mu-maildir.c  2010-11-02 00:06:21.000000000 +0900
@@ -328,7 +328,7 @@
 
                /* note, fullpath_s returns a static buffer */
                fullpath = fullpath_s (path, entry->d_name);
-               if (stat (fullpath, &statbuf) != 0) {
+               if (lstat (fullpath, &statbuf) != 0) {
                        g_warning ("stat failed on %s: %s", fullpath,
                                   strerror(errno));
                        return FALSE;




* bump standards version to 3.9.1, no changes necessary


finally a trivial update in the standards version, no change needed.



I hope you will accept this still into squeeze. If there are any
questions please don't hesitate to contact us.

Best wishes

Norbert
------------------------------------------------------------------------
Norbert Preining            preining@{jaist.ac.jp, logic.at, debian.org}
JAIST, Japan                                 TeX Live & Debian Developer
DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
------------------------------------------------------------------------
GANGES (n. rare : colonial Indian)
Leg-rash contracted from playing too much polo. (It is a little-known
fact that Prince Charles is troubled by ganges down the inside of his
arms.)
			--- Douglas Adams, The Meaning of Liff


Reply to: