Bug#596280: unblock: kolabd/2.2.4-20100624-2

["Mathieu Parent (Debian)" <sathieu@debian.org>]

On Wed, Sep 15, 2010 at 7:37 PM, Julien Cristau <jcristau@debian.org> wrote:
> On Tue, Sep 14, 2010 at 18:10:56 +0200, Mathieu Parent (Debian) wrote:
>
>> unblock libkolab-perl/1:2.2.4-20100624-2
>>
>
> +-        &Kolab::log('K', 'Restarting OpenLDAP...');
> +-        system("invoke-rc.d slapd restart &");
> ++        &Kolab::log('K', 'Stopping OpenLDAP...');
> ++        system("invoke-rc.d slapd stop");
> ++        &Kolab::log('K', 'Deleting old slapd config...');
> ++        system("rm -rf $Kolab::config{'ldapserver_confdir'}/slapd.d");
> ++        &Kolab::log('K', 'Converting slapd config... (most errors here can be ignored)');
> ++        system("mkdir $Kolab::config{'ldapserver_confdir'}/slapd.d");
> ++        system("slaptest -f $Kolab::config{'ldapserver_confdir'}/slapd.conf -F $Kolab::config{'ldapserver_confdir'}/slapd.d");
> ++        system("chown -R openldap $Kolab::config{'ldapserver_confdir'}/slapd.d");
> ++        system("chgrp -R openldap $Kolab::config{'ldapserver_confdir'}/slapd.d");
> ++        &Kolab::log('K', 'Starting OpenLDAP...');
> ++        system("invoke-rc.d slapd start");
>
> Doesn't perl have rm, mkdir and chown functions?

Yes. chown is even already used in libkolab-perl.

> Also rm -rf seems like heavy-handed configuration...

The -f is not even needed.

I will upload a better version once libkolab-perl/1:2.2.4-20100624-2
is in testing.

> Unblocked.

Merci ;)

Mathieu