Re: Bugfixes for icinga-core

[Alexander Wirt <formorer@formorer.de>]

Julien Cristau schrieb am Monday, den 13. September 2010:

Hi, 

> > 0003-modify-execv-to-execvp-accepting-4096-cmd-args-for-b.patch,
> > 0004-execvp-searches-in-PATH-too-like-popen-and-returns-i.patch:
> > 1.0.2 included a new heuristic to detect if a check could be executed without
> > a shell to speed up things. Unfortunatly that heuristic had some critical
> > bugs. One of the is that a command can only have 20-1 arguments which often
> > is not enough. The second of the patches fixes PATH lookups for check
> > commands. 
> > 
> Wouldn't it be easier/safer to just fork a shell every time, if the
> heuristic is unreliable?
AFAIR (I don't have the code by hand) we removed the "feature" (I was never
happy with it) in the last version. But so far, just a bugfix for 1.0.3 to
make the changes no to big.  

Alex