Hi, I would like to get bug #536080 [1] fixed with the next point release. A segmentation occurs during startup, which makes the issue grave for all (affected) users. The fix/patch is pretty simply by calling g_type_init() at the right place. The debdiff is attached. I'm DM for this package. Shall/may I upload to proposed-updates myself? Regards, Daniel
diff -u gchempaint-0.8.7/debian/patches/00list gchempaint-0.8.7/debian/patches/00list --- gchempaint-0.8.7/debian/patches/00list +++ gchempaint-0.8.7/debian/patches/00list @@ -2,0 +3 @@ +536080_fix_segmentation_fault diff -u gchempaint-0.8.7/debian/changelog gchempaint-0.8.7/debian/changelog --- gchempaint-0.8.7/debian/changelog +++ gchempaint-0.8.7/debian/changelog @@ -1,3 +1,12 @@ +gchempaint (0.8.7-2+lenny1) stable; urgency=low + + * Upload to stable to fix a segmentation fault. + * debian/patches/536080_fix_segmentation_fault.dpatch: Added. + - lib/theme.cc: Call g_type_init() in the constructor and fix a + segmentation fault (closes: #536080). + + -- Daniel Leidert (dale) <daniel.leidert@wgdd.de> Sat, 23 Jan 2010 15:44:55 +0100 + gchempaint (0.8.7-2) unstable; urgency=high * debian/rules (LDFLAGS): We have to accept unresolved symobols in the only in patch2: unchanged: --- gchempaint-0.8.7.orig/debian/patches/536080_fix_segmentation_fault.dpatch +++ gchempaint-0.8.7/debian/patches/536080_fix_segmentation_fault.dpatch @@ -0,0 +1,29 @@ +#! /bin/sh /usr/share/dpatch/dpatch-run +## 536080_fix_segmentation_fault.dpatch by Daniel Leidert (dale) <daniel.leidert@wgdd.de> +## +## All lines beginning with `## DP:' are a description of the patch. +## DP: Fix a segmentation fault because of g_type_init() not being called +## DP: at the right place. +## DP: +## DP: <URL:http://bugs.debian.org/536080> + +@DPATCH@ +diff -urNad gchempaint~/lib/theme.cc gchempaint/lib/theme.cc +--- gchempaint~/lib/theme.cc 2007-12-13 13:30:31.000000000 +0100 ++++ gchempaint/lib/theme.cc 2010-01-23 15:23:55.628445971 +0100 +@@ -183,6 +183,7 @@ + bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8"); + #endif + GError *error = NULL; ++ g_type_init (); + m_ConfClient = gconf_client_get_default (); + gconf_client_add_dir (m_ConfClient, "/apps/gchempaint/settings", GCONF_CLIENT_PRELOAD_ONELEVEL, NULL); + GCU_GCONF_GET (ROOTDIR"bond-length", float, DefaultBondLength, 140.) +@@ -241,7 +242,6 @@ + + gcpThemeManager::~gcpThemeManager () + { +- g_type_init (); + gconf_client_notify_remove (m_ConfClient, m_NotificationId); + gconf_client_remove_dir (m_ConfClient, "/apps/gchempaint/settings", NULL); + g_object_unref (m_ConfClient);
Attachment:
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil