openswan 2.6.28+dfsg-5 unblock request
On Thu, Dec 16, 2010 at 08:50:35PM +0100, Julien Cristau wrote:
> On Mon, Nov 29, 2010 at 11:03:18 +0100, Harald Jenny wrote:
>
> > diff -Nru openswan-2.6.28+dfsg/debian/patches/08-initd-configcheck.dpatch openswan-2.6.28+dfsg/debian/patches/08-initd-configcheck.dpatch
> > --- openswan-2.6.28+dfsg/debian/patches/08-initd-configcheck.dpatch 1970-01-01 01:00:00.000000000 +0100
> > +++ openswan-2.6.28+dfsg/debian/patches/08-initd-configcheck.dpatch 2010-11-26 10:01:06.000000000 +0100
> > @@ -0,0 +1,83 @@
> > +#! /bin/sh /usr/share/dpatch/dpatch-run
> > +## /tmp/initd-configcheck.patch.dpatch by Harald Jenny <harald@a-little-linux-box.at>
> > +##
> > +## All lines beginning with `## DP:' are a description of the patch.
> > +## DP: jdefg
> > +## DP: Author: Harald Jenny <harald@a-little-linux-box.at>
> > +## DP:
> > +## DP:
> > +## DP: check ipsec config before doing start/restart/reload
> > +
> > +@DPATCH@
> > +
> > +diff --git a/programs/setup/setup.in b/programs/setup/setup.in
> > +index bf233fb..ce7064d 100755
> > +--- a/programs/setup/setup.in
> > ++++ b/programs/setup/setup.in
> > +@@ -68,6 +68,9 @@ then
> > + export IPSEC_DIR IPSEC_CONFS IPSEC_LIBDIR IPSEC_EXECDIR
> > + fi
> > +
> > ++# Does not make any sense at all to continue without the main binary
> > ++test -x $IPSEC_SBINDIR/ipsec || exit 5
> > ++
> > + # misc setup
> > + umask 022
> > +
>
> This looks wrong. The init script must exit successfully and silently
> if the package is removed but not purged.
>
> Cheers,
> Julien
Dear release team,
a new version was uploaded to unstable which changes the exit code in the above
mentioned patch from 5 to 0 (only effective change apart from adding the
according changelog entries). In order to avoid spamming the mailing list I did
not attach debdiffs but made them available at
http://i-am.a-little-linux-box.at/openswan/openswan-debdiff_3-5 (diff from
version -3 currently in testing to version -5 new in unstable) and
http://i-am.a-little-linux-box.at/openswan/openswan-debdiff_4-5 (diff from
version -4 previously in unstable and rejected from testing to version -5 new
in unstable). For further questions please don't hesitate to contact me.
Thanks for your help
Kind regards
Harald Jenny
Reply to: